From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751879AbWJIOkr (ORCPT ); Mon, 9 Oct 2006 10:40:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751886AbWJIOkr (ORCPT ); Mon, 9 Oct 2006 10:40:47 -0400 Received: from mx1.suse.de ([195.135.220.2]:57539 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1751879AbWJIOkq (ORCPT ); Mon, 9 Oct 2006 10:40:46 -0400 Date: Mon, 09 Oct 2006 16:40:45 +0200 Message-ID: From: Takashi Iwai To: Amit Choudhary Cc: Linux Kernel Subject: Re: [KJ] [PATCH] sound/isa/gus/interwave.c: check kmalloc() return value. In-Reply-To: <20061007003155.1374ed08.amit2030@gmail.com> References: <20061007003155.1374ed08.amit2030@gmail.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25) (eggplant) (+CVS-20060326) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Sat, 7 Oct 2006 00:31:55 -0700, Amit Choudhary wrote: > > Description: Check the return value of kmalloc() in function snd_interwave_pnp(), in file sound/isa/gus/interwave.c. > > Signed-off-by: Amit Choudhary Thanks, I merged these patches to ALSA tree now. Takashi > > diff --git a/sound/isa/gus/interwave.c b/sound/isa/gus/interwave.c > index ea69f25..5282fbb 100644 > --- a/sound/isa/gus/interwave.c > +++ b/sound/isa/gus/interwave.c > @@ -564,6 +564,8 @@ static int __devinit snd_interwave_pnp(i > struct pnp_resource_table * cfg = kmalloc(sizeof(struct pnp_resource_table), GFP_KERNEL); > int err; > > + if (!cfg) > + return -ENOMEM; > iwcard->dev = pnp_request_card_device(card, id->devs[0].id, NULL); > if (iwcard->dev == NULL) { > kfree(cfg); > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >