From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F59C4332F for ; Fri, 14 Jan 2022 16:19:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243279AbiANQTM (ORCPT ); Fri, 14 Jan 2022 11:19:12 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:52960 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243278AbiANQTH (ORCPT ); Fri, 14 Jan 2022 11:19:07 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 6CAD41F3CE; Fri, 14 Jan 2022 16:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1642177146; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Spkw61CbNChV5xZqQLKYPzypFfNleWy1BM/D9zEVuhA=; b=Iz++ekoL0FTxQxvkFvp9uvjhmdZBAXfcnp6RJmdkXIRsdRDGaUoBNCT30iSlt4KTeF/ADU v9qN17GBZvN7YmJehZI5Q+6xpSWKyaXdB3LD7CI4HaeHo6q9KgR8gMsLDd6vUo/0PyCxVr Qe7MVB+xXq5Lj7NxxzkrgGfMUZqYbIA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1642177146; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Spkw61CbNChV5xZqQLKYPzypFfNleWy1BM/D9zEVuhA=; b=AebJHghtAS1P8nayA20bWwUXSE3u+l3ztg0QK+Q+jRBIIOck1+VPuTUhKRCF95E3d8dtTt Cl9KrJ/VACqaRYAA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 5CE1AA3B84; Fri, 14 Jan 2022 16:19:06 +0000 (UTC) Date: Fri, 14 Jan 2022 17:19:06 +0100 Message-ID: From: Takashi Iwai To: Lucas Tanure Cc: "Rafael J . Wysocki" , Len Brown , Hans de Goede , Mark Gross , Jaroslav Kysela , Takashi Iwai , , , , , Subject: Re: [PATCH 5/5] ACPI / scan: Create platform device for CLSA0100 In-Reply-To: <20220113170728.1953559-5-tanureal@opensource.cirrus.com> References: <20220113170728.1953559-1-tanureal@opensource.cirrus.com> <20220113170728.1953559-5-tanureal@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Jan 2022 18:07:28 +0100, Lucas Tanure wrote: > > The ACPI device with CLSA0100 is a sound card with > multiple instances of CS35L41 connected by I2C to > the main CPU. > > We add an ID to the i2c_multi_instantiate_idsi list > to enumerate all I2C slaves correctly. > > Signed-off-by: Lucas Tanure I think it's better to merge this from sound git tree together with others in the patch set, presumably for rc1. It'd be great if ACPI people can take a review and give an ack/nack. Thanks! Takashi > --- > drivers/acpi/scan.c | 2 ++ > drivers/platform/x86/i2c-multi-instantiate.c | 8 ++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index c215bc8723d0..2a68031d953e 100644 > --- a/drivers/acpi/scan.c > +++ b/drivers/acpi/scan.c > @@ -1753,6 +1753,8 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device) > */ > {"BCM4752", }, > {"LNV4752", }, > + /* Non-conforming _HID for Cirrus Logic already released */ > + {"CLSA0100", }, > {} > }; > > diff --git a/drivers/platform/x86/i2c-multi-instantiate.c b/drivers/platform/x86/i2c-multi-instantiate.c > index 4956a1df5b90..a51a74933fa9 100644 > --- a/drivers/platform/x86/i2c-multi-instantiate.c > +++ b/drivers/platform/x86/i2c-multi-instantiate.c > @@ -147,6 +147,12 @@ static const struct i2c_inst_data int3515_data[] = { > {} > }; > > +static const struct i2c_inst_data cs35l41_hda[] = { > + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, > + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, > + {} > +}; > + > /* > * Note new device-ids must also be added to i2c_multi_instantiate_ids in > * drivers/acpi/scan.c: acpi_device_enumeration_by_parent(). > @@ -155,6 +161,8 @@ static const struct acpi_device_id i2c_multi_inst_acpi_ids[] = { > { "BSG1160", (unsigned long)bsg1160_data }, > { "BSG2150", (unsigned long)bsg2150_data }, > { "INT3515", (unsigned long)int3515_data }, > + /* Non-conforming _HID for Cirrus Logic already released */ > + { "CLSA0100", (unsigned long)cs35l41_hda }, > { } > }; > MODULE_DEVICE_TABLE(acpi, i2c_multi_inst_acpi_ids); > -- > 2.34.1 >