From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC625C433E0 for ; Fri, 12 Mar 2021 13:15:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 981B764F59 for ; Fri, 12 Mar 2021 13:15:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231448AbhCLNOx (ORCPT ); Fri, 12 Mar 2021 08:14:53 -0500 Received: from mx2.suse.de ([195.135.220.15]:35000 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbhCLNOv (ORCPT ); Fri, 12 Mar 2021 08:14:51 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7A76BB0D7; Fri, 12 Mar 2021 13:14:50 +0000 (UTC) Date: Fri, 12 Mar 2021 14:14:50 +0100 Message-ID: From: Takashi Iwai To: Xu Wang Cc: tiwai@suse.com, perex@perex.cz, joe@perches.com, jgg@ziepe.ca, chao@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: sb: Remove extra brackets In-Reply-To: <20210312093625.65650-1-vulab@iscas.ac.cn> References: <20210312093625.65650-1-vulab@iscas.ac.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Mar 2021 10:36:25 +0100, Xu Wang wrote: > > Remove extra brackets. > > Signed-off-by: Xu Wang Thanks for the patch. But this kind of change alone makes little benefit, as it doesn't improve the readability significantly. So I'd take such a change only if it's really needed, e.g. if it's a preliminary work for the further real fixes. Takashi > --- > sound/isa/sb/sb16_csp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/isa/sb/sb16_csp.c b/sound/isa/sb/sb16_csp.c > index 8635a2b6b36b..2c292bf0f5ae 100644 > --- a/sound/isa/sb/sb16_csp.c > +++ b/sound/isa/sb/sb16_csp.c > @@ -769,7 +769,7 @@ static int snd_sb_csp_autoload(struct snd_sb_csp * p, snd_pcm_format_t pcm_sfmt, > > p->running = 0; /* clear autoloaded flag */ > p->mode = 0; > - return (err); > + return err; > } else { > p->running = SNDRV_SB_CSP_ST_AUTO; /* set autoloaded flag */ > p->acc_width = SNDRV_SB_CSP_SAMPLE_16BIT; /* only 16 bit data */ > -- > 2.17.1 >