From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E48B3C64E69 for ; Thu, 19 Nov 2020 15:44:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D93E22256 for ; Thu, 19 Nov 2020 15:44:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728804AbgKSPoO (ORCPT ); Thu, 19 Nov 2020 10:44:14 -0500 Received: from mx2.suse.de ([195.135.220.15]:33770 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728793AbgKSPoL (ORCPT ); Thu, 19 Nov 2020 10:44:11 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D6F3BAD60; Thu, 19 Nov 2020 15:44:08 +0000 (UTC) Date: Thu, 19 Nov 2020 16:44:08 +0100 Message-ID: From: Takashi Iwai To: Daniel Cc: Jaroslav Kysela , Takashi Iwai , Hector Martin , Alexander Tsoy , Kai-Heng Feng , =?UTF-8?B?RnJhbnRpxaFlayBLdcSNZXJh?= , Dmitry Panchenko , Gregor Pintar , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio : Add support for the Pioneer DJ DDJ-RR controller. In-Reply-To: <20201110061742.78033-1-dmanlfc@gmail.com> References: <20201110061742.78033-1-dmanlfc@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Nov 2020 07:17:40 +0100, Daniel wrote: > > --- > sound/usb/quirks-table.h | 56 +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 55 insertions(+), 1 deletion(-) > > diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h > index 3c1697f6b60c..a39233cb4d72 100644 > --- a/sound/usb/quirks-table.h > +++ b/sound/usb/quirks-table.h > @@ -3530,7 +3530,61 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"), > } > } > }, > - > +{ > + /* > + * PIONEER DJ DDJ-RR > + * PCM is 6 channels out & 4 channels in @ 44.1 fixed > + */ > + USB_DEVICE_VENDOR_SPEC(0x2b73, 0x000d), > + .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) { > + .ifnum = QUIRK_ANY_INTERFACE, > + .type = QUIRK_COMPOSITE, > + .data = (const struct snd_usb_audio_quirk[]) { > + { > + .ifnum = 0, > + .type = QUIRK_AUDIO_FIXED_ENDPOINT, > + .data = &(const struct audioformat) { > + .formats = SNDRV_PCM_FMTBIT_S24_3LE, > + .channels = 6, //Master, Headphones & Booth > + .iface = 0, > + .altsetting = 1, > + .altset_idx = 1, > + .endpoint = 0x01, > + .ep_attr = USB_ENDPOINT_XFER_ISOC| > + USB_ENDPOINT_SYNC_ASYNC, > + .rates = SNDRV_PCM_RATE_44100, > + .rate_min = 44100, > + .rate_max = 44100, > + .nr_rates = 1, > + .rate_table = (unsigned int[]) { 44100 } > + } > + }, > + { > + .ifnum = 0, > + .type = QUIRK_AUDIO_FIXED_ENDPOINT, > + .data = &(const struct audioformat) { > + .formats = SNDRV_PCM_FMTBIT_S24_3LE, > + .channels = 4, //2x RCA inputs (CH1 & CH2) > + .iface = 0, > + .altsetting = 1, > + .altset_idx = 1, > + .endpoint = 0x82, > + .ep_attr = USB_ENDPOINT_XFER_ISOC| > + USB_ENDPOINT_SYNC_ASYNC| > + USB_ENDPOINT_USAGE_IMPLICIT_FB, > + .rates = SNDRV_PCM_RATE_44100, > + .rate_min = 44100, > + .rate_max = 44100, > + .nr_rates = 1, > + .rate_table = (unsigned int[]) { 44100 } > + } > + }, > + { > + .ifnum = -1 > + } > + } > + } > +}, The code change itself looks reasonable, but the patch misses the description completely. Could you give the patch description? Also, a signed-off-by line is mandatory from the legal reason, so please add this together and resubmit the patch. Thanks! Takashi