From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=camR=ZD=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 60444C17445
	for <linux-kernel@archiver.kernel.org>; Mon, 11 Nov 2019 17:20:21 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 3D2F120656
	for <linux-kernel@archiver.kernel.org>; Mon, 11 Nov 2019 17:20:21 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727027AbfKKRUU (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 11 Nov 2019 12:20:20 -0500
Received: from mx2.suse.de ([195.135.220.15]:50538 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1726845AbfKKRUT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 11 Nov 2019 12:20:19 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.220.254])
        by mx1.suse.de (Postfix) with ESMTP id F37BCAC2C;
        Mon, 11 Nov 2019 17:20:17 +0000 (UTC)
Date:   Mon, 11 Nov 2019 18:20:17 +0100
Message-ID: <s5heeyeuy7i.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "RAVULAPATI, VISHNU VARDHAN RAO" 
        <Vishnuvardhanrao.Ravulapati@amd.com>
Cc:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@alsa-project.org>,
        Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@amd.com>,
        open list <linux-kernel@vger.kernel.org>,
        Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        "Agrawal, Akshu" <Akshu.Agrawal@amd.com>,
        Mark Brown <broonie@kernel.org>,
        "djkurtz@google.com" <djkurtz@google.com>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        Colin Ian King <colin.king@canonical.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [alsa-devel] [RESEND PATCH v4 1/6] ASoC: amd:Create multiple I2S platform device Endpoint
In-Reply-To: <DM6PR12MB3868D380B280936C902FF67BE7740@DM6PR12MB3868.namprd12.prod.outlook.com>
References: <1573483794-8921-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
        <1573483794-8921-2-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 11 Nov 2019 18:16:25 +0100,
RAVULAPATI, VISHNU VARDHAN RAO wrote:
> 
> > +             pdevinfo[2].name = "acp3x_i2s_playcap";
> > +             pdevinfo[2].id = 1;
> > +             pdevinfo[2].parent = &pci->dev;
> > +             pdevinfo[2].num_res = 1;
> > +             pdevinfo[2].res = &adata->res[2];
> > +             for (i = 0; i < ACP3x_DEVS ; i++) {
> > +                     adata->pdev[i] =
> > +                             platform_device_register_full(&pdevinfo[i]);
> > +                     IS_ERR(adata->pdev[i]) {
> 
> how does this even compile?
> 
> I have not faced any issue of compilation.
> Can I know what is wrong with it please so that it can be re checked.

The "if" is missing around IS_ERR() in the above line.
It should have been
			if (IS_ERR(adata->pdev[i])) {
				.....


It's interesting the code didn't give any compile warning or error,
indeed.


thanks,

Takashi