From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751337AbdKUQ0v (ORCPT <rfc822;w@1wt.eu>);
        Tue, 21 Nov 2017 11:26:51 -0500
Received: from mx2.suse.de ([195.135.220.15]:35181 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751187AbdKUQ0u (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 21 Nov 2017 11:26:50 -0500
Date: Tue, 21 Nov 2017 17:26:48 +0100
Message-ID: <s5heforvbqv.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Con Kolivas <con@kolivas.org>,
        Bhumika Goyal <bhumirks@gmail.com>,
        Stephen Barber <smbarber@chromium.org>, alsa-devel@alsa-project.org,
        LKML <linux-kernel@vger.kernel.org>,
        Kostya Serebryany <kcc@google.com>,
        syzkaller <syzkaller@googlegroups.com>,
        Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [alsa-devel] usb/sound: slab-out-of-bounds in parse_audio_unit
In-Reply-To: <CAAeHK+wr2ka_B6RAw+0ygzb_YRoATOZF89HDNoOCVj+4Wm0j1Q@mail.gmail.com>
References: <CAAeHK+wr2ka_B6RAw+0ygzb_YRoATOZF89HDNoOCVj+4Wm0j1Q@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 21 Nov 2017 14:51:56 +0100,
Andrey Konovalov wrote:
> 
> Hi!
> 
> I've got the following report while fuzzing the kernel with syzkaller.
> 
> On commit e1d1ea549b57790a3d8cf6300e6ef86118d692a3 (4.15-rc1).
> 
> ==================================================================
> BUG: KASAN: slab-out-of-bounds in parse_audio_unit+0x2e08/0x31d0
> Read of size 1 at addr ffff88006998ff20 by task kworker/1:1/1495
> 
> CPU: 1 PID: 1495 Comm: kworker/1:1 Not tainted 4.14.0-57501-g9284d204d604 #119
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
> Workqueue: usb_hub_wq hub_event
> Call Trace:
>  __dump_stack lib/dump_stack.c:17
>  dump_stack+0xe1/0x157 lib/dump_stack.c:53
>  print_address_description+0x71/0x234 mm/kasan/report.c:252
>  kasan_report_error mm/kasan/report.c:351
>  kasan_report+0x173/0x270 mm/kasan/report.c:409
>  __asan_report_load1_noabort+0x19/0x20 mm/kasan/report.c:427
>  parse_audio_feature_unit sound/usb/mixer.c:1472

Looks like that a malformed feature unit descriptor is passed while
the usb-audio driver is too naive to believe in a perfect world.
I'll provide a fix patch.


thanks,

Takashi