From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752824AbdBUWkd (ORCPT ); Tue, 21 Feb 2017 17:40:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:46695 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbdBUWkZ (ORCPT ); Tue, 21 Feb 2017 17:40:25 -0500 Date: Tue, 21 Feb 2017 23:40:22 +0100 Message-ID: From: Takashi Iwai To: "Arnd Bergmann" Cc: "Jaroslav Kysela" , , "Jerome Anand" , "Pierre-Louis Bossart" , Subject: Re: [PATCH] ALSA: x86: hdmi: select CONFIG_SND_PCM In-Reply-To: <20170221220255.242105-1-arnd@arndb.de> References: <20170221220255.242105-1-arnd@arndb.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Feb 2017 23:02:37 +0100, Arnd Bergmann wrote: > > The newly added driver uses the PCM helpers and fails to link if they are disabled: > > sound/built-in.o: In function `hdmi_lpe_audio_runtime_suspend': > intel_hdmi_audio.c:(.text+0x15906): undefined reference to `snd_pcm_suspend' > sound/built-in.o: In function `had_pcm_hw_params': > intel_hdmi_audio.c:(.text+0x15ac7): undefined reference to `snd_pcm_lib_malloc_pages' > sound/built-in.o: In function `had_pcm_open': > intel_hdmi_audio.c:(.text+0x15d49): undefined reference to `snd_pcm_hw_constraint_integer' > > This uses a Kconfig 'select' statement to make sure they are enabled. > > Fixes: 5dab11d89777 ("ALSA: x86: hdmi: Add audio support for BYT and CHT") > Signed-off-by: Arnd Bergmann Thanks, applied. Takashi