From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752795AbdBGGZC (ORCPT ); Tue, 7 Feb 2017 01:25:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:39305 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752365AbdBGGZB (ORCPT ); Tue, 7 Feb 2017 01:25:01 -0500 Date: Tue, 07 Feb 2017 07:24:56 +0100 Message-ID: From: Takashi Iwai To: Takashi Sakamoto Cc: Satendra Singh Thakur , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, hemanshu.s@samsung.com, nishant.s4@samsung.com Subject: Re: [RFC v2] [ALSA][CONTROL] 1. Added 2 ioctls for reading/writing values of multiple controls in one go (at once) 2. Restructured the code for read/write of a single control In-Reply-To: <0fece5db-0bde-19eb-1863-bead3e86ce4d@sakamocchi.jp> References: <1486099688-8057-1-git-send-email-satendra.t@samsung.com> <0fece5db-0bde-19eb-1863-bead3e86ce4d@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Feb 2017 05:33:05 +0100, Takashi Sakamoto wrote: > > On Feb 3 2017 16:24, Takashi Iwai wrote: > > On Thu, 02 Feb 2017 04:45:48 +0100, > > Takashi Sakamoto wrote: > >> > >> I'm _strongly_ interested in your two patches, because it has a > >> potentiality to purge ASoC abuse of TLV feature, which was introduced > >> in 2014 with a bad reviewing process. > > > > I don't think it can be a replacement for the extended TLV usages. > > The proposed API is nothing but a loop of ctl elem read/write, and I'm > > not sure whether it worth to introduce the new ioctls just for that. > > In my opinion, an idea to handle several control elements in one system > call could perhaps overcome current limitation of control elements, > which comes from definition of 'struct snd_ctl_elem_value'. Aim of the > abuse of TLV feature in ASoC part essentially comes from the > limitation, as long as I understand. Yes, it's the limitation, but it won't be eased by this kind of patch. The TLV usage came just because of its required data size, sometimes over mega bytes. It's not about the number of elements. It's about the data size a single element needs to deal with. Takashi