From: Takashi Iwai <tiwai@suse.de>
To: "Bhumika Goyal" <bhumirks@gmail.com>
Cc: <alsa-devel@alsa-project.org>, <julia.lawall@lip6.fr>,
<perex@perex.cz>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] sound: pci: cs46xx: constify snd_pcm_ops structures
Date: Thu, 26 Jan 2017 17:03:46 +0100 [thread overview]
Message-ID: <s5hefzpiza5.wl-tiwai@suse.de> (raw)
In-Reply-To: <1485445265-19790-1-git-send-email-bhumirks@gmail.com>
On Thu, 26 Jan 2017 16:41:05 +0100,
Bhumika Goyal wrote:
>
> Declare snd_pcm_ops structures as const as they are either stored in the
> ops field of a snd_pcm_substream structure or passed as an argument to
> the function snd_pcm_set_ops. The function argument and the ops field
> are of type const, so snd_pcm_ops structures having this property
> can be made const too.
>
> File size before: sound/pci/cs46xx/cs46xx_lib.o
> text data bss dec hex filename
> 26047 5304 16 31367 7a87 sound/pci/cs46xx/cs46xx_lib.o
>
> File size after: sound/pci/cs46xx/cs46xx_lib.o
> text data bss dec hex filename
> 27335 4036 16 31387 7a9b sound/pci/cs46xx/cs46xx_lib.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> Changes in v2:
> * test build the patch with CONFIG_SND_CS46XX_NEW_DSP=y
Applied, thanks.
Takashi
prev parent reply other threads:[~2017-01-26 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 15:41 Bhumika Goyal
2017-01-26 16:03 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hefzpiza5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®