From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933826AbcIUNaW (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Sep 2016 09:30:22 -0400
Received: from mx2.suse.de ([195.135.220.15]:60939 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932575AbcIUNaV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Sep 2016 09:30:21 -0400
Date: Wed, 21 Sep 2016 15:30:19 +0200
Message-ID: <s5heg4dl6s4.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Randy Dunlap <randy.dunlap@oracle.com>, alsa-devel@alsa-project.org,
        Valdis Kletnieks <Valdis.Kletnieks@vt.edu>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP
In-Reply-To: <b9ed1809-b48a-5e72-b815-f5ad073520d1@sakamocchi.jp>
References: <86590.1474409693@turing-police.cc.vt.edu>
        <046fe4be-f3e8-0088-8b1d-ed94bb9ef914@sakamocchi.jp>
        <s5hk2e5l97y.wl-tiwai@suse.de>
        <b9ed1809-b48a-5e72-b815-f5ad073520d1@sakamocchi.jp>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 21 Sep 2016 15:25:43 +0200,
Takashi Sakamoto wrote:
> 
> On Sep 21 2016 21:37, Takashi Iwai wrote:
> > On Wed, 21 Sep 2016 03:56:05 +0200,
> > Takashi Sakamoto wrote:
> >>
> >> On Sep 21 2016 07:14, Valdis Kletnieks wrote:
> >>> ALSA - snd-usb-line6 depends on CONFIG_SND_HWDEP
> >>>
> >>> ERROR: "snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined!
> >>> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> >>> make[1]: *** [__modpost] Error 1
> >>>
> >>> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> >>
> >> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> >>
> >> As a nitpicking, I think it better to change the subject line with a
> >> prefix of 'ALSA: line6:' or 'ALSA: usb-line6:', following to our
> >> fashion.
> > 
> > Yes, I modified the subject line and added fixes tag.
> 
> Thanks.
> 
> As another issue, I can see sparse (v0.5.0) errors:
> 
> sound/usb/line6/driver.c:274:43: error: cannot size expression
> sound/usb/line6/driver.c:275:16: error: cannot size expression
> sound/usb/line6/driver.c:276:16: error: cannot size expression
> sound/usb/line6/driver.c:277:16: error: cannot size expression
> 
> And this fix can suppresses them:
> 
> $ git diff sound/usb/line6
> diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c
> index f9224ec..ad7efc0 100644
> --- a/sound/usb/line6/driver.c
> +++ b/sound/usb/line6/driver.c
> @@ -30,7 +30,7 @@
>  /*
>         This is Line 6's MIDI manufacturer ID.
>  */
> -const unsigned char line6_midi_id[] = {
> +const unsigned char line6_midi_id[3] = {
>         0x00, 0x01, 0x0c
>  };
>  EXPORT_SYMBOL_GPL(line6_midi_id);
> 
> Besides, there's a difference of the declaration between header and code:
> $ cat sound/usb/line6/driver.h
> ...
> extern const unsigned char line6_midi_id[3];
> 
> This is quite minor. So I can't judge to fix it or not... What do you
> think about it?

The only problem I can see is the inconsistency between the
declaration and the definition.  So yes, we should align to [3], if
we keep the declaration as is.  (And actually it's sometimes safer to
have the explicit array size.)


thanks,

Takashi