From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932464AbbLVJ6u (ORCPT ); Tue, 22 Dec 2015 04:58:50 -0500 Received: from mx2.suse.de ([195.135.220.15]:48745 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932164AbbLVJ6r (ORCPT ); Tue, 22 Dec 2015 04:58:47 -0500 Date: Tue, 22 Dec 2015 10:58:45 +0100 Message-ID: From: Takashi Iwai To: Geliang Tang Cc: Jaroslav Kysela , Takashi Iwai , Ricard Wanderlof , Johan =?UTF-8?B?UmFzdMOpbg==?= , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ALSA: usb-audio: use list_for_each_entry_continue_reverse In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Dec 2015 16:55:39 +0100, Geliang Tang wrote: > > For better readability, use list_for_each_entry_continue_reverse() > in have_dup_chmap(). > > Signed-off-by: Geliang Tang Applied, thanks. Takashi > --- > sound/usb/stream.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/usb/stream.c b/sound/usb/stream.c > index 8ee14f2..c4dc577 100644 > --- a/sound/usb/stream.c > +++ b/sound/usb/stream.c > @@ -125,11 +125,9 @@ static int usb_chmap_ctl_info(struct snd_kcontrol *kcontrol, > static bool have_dup_chmap(struct snd_usb_substream *subs, > struct audioformat *fp) > { > - struct list_head *p; > + struct audioformat *prev = fp; > > - for (p = fp->list.prev; p != &subs->fmt_list; p = p->prev) { > - struct audioformat *prev; > - prev = list_entry(p, struct audioformat, list); > + list_for_each_entry_continue_reverse(prev, &subs->fmt_list, list) { > if (prev->chmap && > !memcmp(prev->chmap, fp->chmap, sizeof(*fp->chmap))) > return true; > -- > 2.5.0 > > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >