From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757975AbaHZMcH (ORCPT ); Tue, 26 Aug 2014 08:32:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43434 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757765AbaHZMcF (ORCPT ); Tue, 26 Aug 2014 08:32:05 -0400 Date: Tue, 26 Aug 2014 14:32:04 +0200 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: pci: ctxfi: fix broken user-visible string In-Reply-To: <1409055734-2777-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 26 Aug 2014 17:52:14 +0530, Sudip Mukherjee wrote: > > fixed broken user visible strings This text just repeats what the summary line says. Instead, you should write *why* the patch is needed. Ditto for the previous patch. > Signed-off-by: Sudip Mukherjee > --- > > I am not exactly sure about the patch as some lines after fixing has crossed the limit of 80 characters. > But the coding style says : > "never break user-visible strings such as printk messages, because that breaks the ability to grep for them" Right, the 80 chars rule can be a guideline, it doesn't always force the codes to fit within. A long message string is clearly such a case. Takashi