From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbaBLLbJ (ORCPT ); Wed, 12 Feb 2014 06:31:09 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38382 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751894AbaBLLbH (ORCPT ); Wed, 12 Feb 2014 06:31:07 -0500 Date: Wed, 12 Feb 2014 12:31:05 +0100 Message-ID: From: Takashi Iwai To: Charles Keepax Cc: broonie@kernel.org, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, dmitry.torokhov@gmail.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, cw00.choi@samsung.com, myungjoo.ham@samsung.com Subject: Re: [alsa-devel] [PATCH] ASoC: dapm: Add locking to snd_soc_dapm_xxxx_pin functions In-Reply-To: <20140212112640.GE16684@opensource.wolfsonmicro.com> References: <20140210110536.GB6856@opensource.wolfsonmicro.com> <20140212112640.GE16684@opensource.wolfsonmicro.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 12 Feb 2014 11:26:40 +0000, Charles Keepax wrote: > > On Mon, Feb 10, 2014 at 02:05:26PM +0100, Takashi Iwai wrote: > > At Mon, 10 Feb 2014 11:05:36 +0000, > > Charles Keepax wrote: > > > > > > > > > Actually, this fixes also the double-lock in snd_soc_dapm_sync() call > > in the line below the above. snd_soc_dapm_sync() itself takes > > mutex_lock_nested(). > > Yeah spotted that as I was going through will do this in a > seperate patch if this one doesn't go in. As the deadlock seems present since long time ago, it'd be better to have a fix patch (for stable kernels), then move to the new scheme, if any. Takashi