From: Takashi Iwai <tiwai@suse.de>
To: "Li, Yan I" <yan.i.li@intel.com>
Cc: Tobyn Bertram <tobynbertram@hotmail.com>,
"'Dmitry Torokhov'" <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"Ding, Jian-feng" <jian-feng.ding@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"meego-kernel@lists.meego.com" <meego-kernel@lists.meego.com>
Subject: Re: [PATCH v2] Input: Bug 18122 - Support Lenovo S10-3t's 2-button ClickPad
Date: Wed, 01 Dec 2010 07:04:19 +0100 [thread overview]
Message-ID: <s5heia2ni58.wl%tiwai@suse.de> (raw)
In-Reply-To: <20101201041102.GC3411@thyme.bj.intel.com>
At Wed, 1 Dec 2010 12:11:04 +0800,
Li, Yan I wrote:
>
> On Tue, Nov 30, 2010 at 11:48:12PM +0800, Tobyn Bertram wrote:
> > I do not have a S10-3t. I have a HP DV7t with a standard 1 button Clickpad.
> > I am sorry for any confusion.
>
> Thank you. This clarify the S10-3t touchpad mystery. So I think my v2
> patch is valid.
>
> > I think that 2 different Clickpads will need to be defined: 1 button
> > Clickpads and 2 button Clickpads. Maybe like this?
> >
> > #define SYN_CAP_CLICKPAD1BTN(ex0c) ((ex0c) & 0x100000)
> > #define SYN_CAP_CLICKPAD2BTN(ex0c) ((ex0c) & 0x000100)
>
> Maybe, although we don't have any code that needs
> SYN_CAP_CLICKPAD2BTN() so far, only 1-button clickpad needs special
> handling, but it's good to have a more precise name.
Agreed. Also, it's interesting to see how 2-button clickpad devices
behave in multi-touch mode...
thanks,
Takashi
next prev parent reply other threads:[~2010-12-01 6:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-27 3:56 [PATCH] Input: Lenovo S10-3t's touchpad support Yan Li
2010-11-27 7:55 ` Dmitry Torokhov
2010-11-30 2:18 ` Li, Yan I
2010-11-30 7:12 ` Takashi Iwai
2010-11-30 8:09 ` Li, Yan I
2010-11-30 7:44 ` [PATCH v2] Input: Bug 18122 - Support Lenovo S10-3t's 2-button ClickPad Yan Li
2010-11-30 7:50 ` Dmitry Torokhov
2010-11-30 8:08 ` Li, Yan I
2010-11-30 15:48 ` Tobyn Bertram
2010-12-01 4:11 ` Li, Yan I
2010-12-01 6:04 ` Takashi Iwai [this message]
[not found] ` <BAY130-W15C8BF6B2994FAE083FAF5DE260@phx.gbl>
2010-12-01 7:18 ` Li, Yan I
2010-12-01 7:23 ` Dmitry Torokhov
2010-12-01 7:46 ` Dmitry Torokhov
2010-12-01 8:01 ` Li, Yan I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5heia2ni58.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=jian-feng.ding@intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meego-kernel@lists.meego.com \
--cc=tobynbertram@hotmail.com \
--cc=yan.i.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®