From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752237Ab0CBJzf (ORCPT ); Tue, 2 Mar 2010 04:55:35 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57454 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940Ab0CBJzV (ORCPT ); Tue, 2 Mar 2010 04:55:21 -0500 Date: Tue, 02 Mar 2010 10:55:19 +0100 Message-ID: From: Takashi Iwai To: Wei Ni Cc: "'Pavel Hofman'" , "'alsa-devel'" , "'linux-kernel'" , "'akpm'" Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio In-Reply-To: <6B4D417B830BC44B8026029FD256F7F1C068B2BA8C@HKMAIL01.nvidia.com> References: <6B4D417B830BC44B8026029FD256F7F1C068B2BA8B@HKMAIL01.nvidia.com> <6B4D417B830BC44B8026029FD256F7F1C068B2BA8C@HKMAIL01.nvidia.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 2 Mar 2010 17:43:28 +0800, Wei Ni wrote: > > Hi, Takashi > 1. About AZX_MAX_CODECS, on our new chipset, the codec_mask=0x31, it means > the codec connect on the slot0, slot4, slot5, and on some GT2xx, the codec > will connect to slot6 or slot7, although these chip at most have 4 codecs. > So I change the AZX_MAX_CODECS to 8 directly. > In hda_intel.c, the azx_command_addr(), azx_response_addr(), and > azx_codec_create() use the AZX_MAX_CODECS, if it set as 4, the driver will > not detect the codecs which connect to slot4~7. Yeah, I understand it. But, as mentioned, changing this to *all* controller chips is dangerous. We have already a quirk for controller chips to set max codecs depending on the chip model. Right now, only teradici chip sets to 1. So, add "#define AZX_DEFAULT_CODECS 4", and use this value unless azx_max_codecs[] is defined. And, for the new controller chip supporting more than 4, it can has 8 in azx_max_codecs[]. Is it feasible? > 2. yes, it's better to merge the hdmi common codes. > 3. About ELD, yes, we need to change the Makefile and Kconfig as well. > Could you help me to change it. In sound/pci/hda/Makefile, hda_eld.c is built into snd-hda-codec-intelhdmi by the following rule: snd-hda-codec-intelhdmi-objs := patch_intelhdmi.o hda_eld.o Since now hda_eld.c is used in two modules, this has to be in the common place, such as snd-hda-codec. For this, uncomment the line: # snd-hda-codec-$(CONFIG_SND_HDA_ELD) += hda_eld.o and remove hda_eld.o from snd-hda-codec-intelhdmi-objs line. For Kconfig, right now we have the definition config SND_HDA_ELD def_bool y depends on SND_HDA_CODEC_INTELHDMI Change depends on like depends on SND_HDA_CODEC_INTELHDMI || SND_HDA_CODEC_NVHDMI This can be done via "select" instead. But, we'd merge all hdmi codes later, so which way to choose is no big matter. thanks, Takashi