From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933666AbZLPHOT (ORCPT ); Wed, 16 Dec 2009 02:14:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932810AbZLPHOR (ORCPT ); Wed, 16 Dec 2009 02:14:17 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39469 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932717AbZLPHOQ (ORCPT ); Wed, 16 Dec 2009 02:14:16 -0500 Date: Wed, 16 Dec 2009 08:14:15 +0100 Message-ID: From: Takashi Iwai To: Dmitry Torokhov Cc: Alex Chiang , linux-kernel , linux-input@vger.kernel.org Subject: Re: synaptics touchpad doesn't click In-Reply-To: <20091216065652.GE2699@core.coreip.homeip.net> References: <20091214173450.GB2373@core.coreip.homeip.net> <20091215034127.GC587@ldl.fc.hp.com> <20091215062628.GA12669@core.coreip.homeip.net> <20091215073358.GC12669@core.coreip.homeip.net> <20091215082518.GD12669@core.coreip.homeip.net> <20091216010506.GA26367@ldl.fc.hp.com> <20091216025934.GA2699@core.coreip.homeip.net> <20091216065652.GE2699@core.coreip.homeip.net> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 15 Dec 2009 22:56:53 -0800, Dmitry Torokhov wrote: > > On Wed, Dec 16, 2009 at 07:50:54AM +0100, Takashi Iwai wrote: > > At Tue, 15 Dec 2009 18:59:34 -0800, > > Dmitry Torokhov wrote: > > > > > > On Tue, Dec 15, 2009 at 06:05:06PM -0700, Alex Chiang wrote: > > > > * Dmitry Torokhov : > > > > > > > > > > The updated patch is below. > > > > > > > > > > -- > > > > > Dmitry > > > > > > > > Should I test this one or wait one more iteration to address > > > > Takashi's last comments? > > > > > > > > > > Actually I think we took the wrong direction with the original patch and > > > we should do what other buttonless devices (bcm5974) do: report touchpad > > > click as left button and have Synaptics X driver provide enhanced > > > support. This way we can have both modes (ClickZones and ClickButtons) > > > and users will get to chose (provided that someone takes time to add > > > that support to Synaptics driver of course ;) ). > > > > My concern is, still, how would you identify this device. Will you > > extend also some ioctls to expose caps and extcaps? Otherwise it's > > difficult to identify this device automatically from the user-space. > > > > No.. Synaptics without right button == ClickPad. So, is there only Clickpad device that has a single button? No other option? > > The user-space can know that it's button-less, yes. But, how can it > > know whether the device should be emulated via ClickZone? > > We can use a driver option to x11 synaptics driver for that, as I > > already sent you another patch. However, the driver option is > > nowadays not preferred because xorg.conf is being dead on new > > systems... > > Driver still takes options, from UDEV/HAL. We could pick one behavior > by default and ovverride, by box vendor/model (DMI). > > > > > Or maybe HAL (or whatever upcoming one) can check the vendor/product > > id of the machine (not the device) to provide the information. OTOH > > this will also need frequent updates. > > Hopefully vendors won;t be flip/flopping between ClickZone and > ClickButtons too much. Still option is better than hardcoding ClickZone > for everyone. Yeah, I agree that hard-coding isn't good, and that's why I first posted separated patches. OTOH, the kernel-side hack makes the device working *as is* even without changing anything else. Takashi