From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1754525AbZFFQhX@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754525AbZFFQhX (ORCPT <rfc822;w@1wt.eu>);
	Sat, 6 Jun 2009 12:37:23 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752535AbZFFQhL
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sat, 6 Jun 2009 12:37:11 -0400
Received: from cantor2.suse.de ([195.135.220.15]:47417 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752632AbZFFQhK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 6 Jun 2009 12:37:10 -0400
Date: Sat, 06 Jun 2009 18:37:11 +0200
Message-ID: <s5heitx8gjs.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: Jiri Slaby <jirislaby@gmail.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [sound] mpd loops on current -next
In-Reply-To: <alpine.LNX.2.00.0906061752040.4067@eeebox2.perex-int.cz>
References: <4A2A8F6A.80705@gmail.com>
	<alpine.LNX.2.00.0906061752040.4067@eeebox2.perex-int.cz>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Sat, 6 Jun 2009 17:52:44 +0200 (CEST),
Jaroslav Kysela wrote:
> 
> On Sat, 6 Jun 2009, Jiri Slaby wrote:
> 
> > Hi,
> >
> > I found a regression in current -next caused by
> > c44941e05900fe85f6091456f9e313b446a97ae9
> > (PCM midlevel: Do not update hw_ptr_jiffies when hw_ptr is not changed)
> 
> Oops. It seems like typo. Could you try this patch, please?

Ah, that's the cause of the bug with PA on the recent driver.
I didn't experience the problem because I myself don't use PA :)

Now merged to sound git tree.


thanks,

Takashi

> 
> diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
> index dd9126b..bf34603 100644
> --- a/sound/core/pcm_lib.c
> +++ b/sound/core/pcm_lib.c
> @@ -371,7 +371,7 @@ int snd_pcm_update_hw_ptr(struct snd_pcm_substream *substream)
>   	    runtime->silence_size > 0)
>   		snd_pcm_playback_silence(substream, new_hw_ptr);
> 
> -	if (runtime->status->hw_ptr != new_hw_ptr)
> +	if (runtime->status->hw_ptr == new_hw_ptr)
>   		return 0;
> 
>   	runtime->hw_ptr_base = hw_base;
> 
>  					Thanks,
>  						Jaroslav
> 
> -----
> Jaroslav Kysela <perex@perex.cz>
> Linux Kernel Sound Maintainer
> ALSA Project, Red Hat, Inc.
>