From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1754202AbYKNGsS@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754202AbYKNGsS (ORCPT <rfc822;w@1wt.eu>);
	Fri, 14 Nov 2008 01:48:18 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750840AbYKNGsA
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 14 Nov 2008 01:48:00 -0500
Received: from cantor.suse.de ([195.135.220.2]:37722 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750734AbYKNGr7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 14 Nov 2008 01:47:59 -0500
Date: Fri, 14 Nov 2008 07:47:49 +0100
Message-ID: <s5hej1els6i.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@elte.hu>,
       Randy Dunlap <randy.dunlap@oracle.com>,
       Stephen Rothwell <sfr@canb.auug.org.au>,
       Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: mmotm 2008-11-13-17-22 uploaded (pc-speaker)
In-Reply-To: <s5hhc6alsop.wl%tiwai@suse.de>
References: <200811140122.mAE1MeAG015836@imap1.linux-foundation.org>
	<491D0A32.1020401@oracle.com>
	<s5hhc6alsop.wl%tiwai@suse.de>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Fri, 14 Nov 2008 07:36:54 +0100,
I wrote:
> 
> At Thu, 13 Nov 2008 21:18:42 -0800,
> Randy Dunlap wrote:
> > 
> > 
> > mmotm-2008-1113-1722/sound/drivers/pcsp/pcsp.c: In function 'snd_card_pcsp_probe':
> > mmotm-2008-1113-1722/sound/drivers/pcsp/pcsp.c:99: error: 'HRTIMER_CB_IRQSAFE' undeclared (first use in this function)
> > 
> > # CONFIG_SND_HRTIMER is not set
> 
> snd-pcsp and CONFIG_SND_HRTIMER are independent.
> The snd-pcsp driver code isn't changed over weeks, thus it must be the
> change in hrtimer side.

It's turned out to be the recent commint in the upstream:

  commit 621a0d5207c18012cb39932f2d9830a11a6cb03d
  Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
  Date:   Wed Nov 12 09:36:35 2008 +0100

    hrtimer: clean up unused callback modes

    Impact: cleanup

    git grep HRTIMER_CB_IRQSAFE revealed half the callback modes are actually
    unused.

    Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

This hits on snd-pcsp driver on linux-next, since it was switched to
use this dropped flag.  Now we get a build error.

Can this commit be reverted?


thanks,

Takashi