From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754235AbYKKRpv (ORCPT ); Tue, 11 Nov 2008 12:45:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751902AbYKKRpn (ORCPT ); Tue, 11 Nov 2008 12:45:43 -0500 Received: from ns2.suse.de ([195.135.220.15]:33767 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbYKKRpn (ORCPT ); Tue, 11 Nov 2008 12:45:43 -0500 Date: Tue, 11 Nov 2008 18:45:34 +0100 Message-ID: From: Takashi Iwai To: Jeremy Fitzhardinge Cc: Isaku Yamahata , Sam Ravnborg , Tony Luck , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix section type conflict in arch/ia64/xen/xen_pv_ops.c In-Reply-To: <4919C43F.3030009@goop.org> References: <49133E11.8050607@goop.org> <20081106214848.GA3579@uranus.ravnborg.org> <20081111081552.GA10955%yamahata@valinux.co.jp> <20081111085617.GD10955%yamahata@valinux.co.jp> <4919C43F.3030009@goop.org> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 11 Nov 2008 09:43:27 -0800, Jeremy Fitzhardinge wrote: > > Isaku Yamahata wrote: > > Here is. > > > > __initdata and const cannot be always a happy pair and > > x86 xen has the potential issue. > > This patch simply removes const from data with __initdata > > under arch/x86/xen/. > > > > No, I think the proper fix is to use __initconst. The problem is that it depends on gcc version which section it goes. Thus __initconst could break some gcc versions as well. Takashi