From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762626AbYD3L6U (ORCPT ); Wed, 30 Apr 2008 07:58:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758254AbYD3L6K (ORCPT ); Wed, 30 Apr 2008 07:58:10 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44888 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756544AbYD3L6J (ORCPT ); Wed, 30 Apr 2008 07:58:09 -0400 Date: Wed, 30 Apr 2008 13:58:06 +0200 Message-ID: From: Takashi Iwai To: Ingo Molnar Cc: Mauro Carvalho Chehab , Andrew Morton , linux-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com, linux-kernel@vger.kernel.org, Mike Galbraith Subject: Re: [patch, -git] media/video/sound build fix, TEA5761/TEA5767 In-Reply-To: <20080430112138.GA11844@elte.hu> References: <20080430110115.GA5633@elte.hu> <20080430111516.GA9954@elte.hu> <20080430111803.GA11628@elte.hu> <20080430112138.GA11844@elte.hu> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 30 Apr 2008 13:21:38 +0200, Ingo Molnar wrote: > > Subject: sound/video: sound/i2c/other/tea575x-tuner.c build fix > From: Ingo Molnar > Date: Tue Apr 29 22:40:31 CEST 2008 > > fix build failure triggered by this config: > > http://redhat.com/~mingo/misc/config-Tue_Apr_29_22_33_36_CEST_2008.bad > > sound/i2c/other/tea575x-tuner.c: In function 'snd_tea575x_ioctl': > sound/i2c/other/tea575x-tuner.c:95: error: 'VIDIOCGCAP' undeclared (first use in this function) > sound/i2c/other/tea575x-tuner.c:95: error: (Each undeclared identifier is reported only once > sound/i2c/other/tea575x-tuner.c:95: error: for each function it appears in.) > sound/i2c/other/tea575x-tuner.c:97: error: storage size of 'v' isn't known > > that code still depends on VIDEO_V4L1_COMPAT APIs. > > Signed-off-by: Ingo Molnar > --- > sound/pci/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > Index: linux/sound/pci/Kconfig > =================================================================== > --- linux.orig/sound/pci/Kconfig > +++ linux/sound/pci/Kconfig > @@ -527,6 +527,7 @@ config SND_FM801_TEA575X > tristate > depends on SND_FM801_TEA575X_BOOL > default SND_FM801 > + select VIDEO_V4L1_COMPAT > > config SND_HDA_INTEL > tristate "Intel HD Audio" This one shouldn't be needed with my patch. Takashi