From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1751635AbXAPQwA@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751635AbXAPQwA (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Jan 2007 11:52:00 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751609AbXAPQv7
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 16 Jan 2007 11:51:59 -0500
Received: from ns.suse.de ([195.135.220.2]:45355 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751794AbXAPQu7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Jan 2007 11:50:59 -0500
Date: Tue, 16 Jan 2007 17:50:57 +0100
Message-ID: <s5hejpu29vy.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Oliver Neukum <oneukum@suse.de>
Cc: Jaroslav Kysela <perex@suse.cz>, linux-sound@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [patch]cleanup and error reporting for sound/core/init.c
In-Reply-To: <200701130737.59435.oneukum@suse.de>
References: <200701121449.58186.oneukum@suse.de>
	<s5h64bcgmzn.wl%tiwai@suse.de>
	<200701130737.59435.oneukum@suse.de>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27)
 (fiddleheads) (+CVS-20060704) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Sat, 13 Jan 2007 07:37:59 +0100,
Oliver Neukum wrote:
> 
> Am Freitag, 12. Januar 2007 18:42 schrieb Takashi Iwai:
> > At Fri, 12 Jan 2007 14:49:57 +0100,
> > Oliver Neukum wrote:
> > > 
> > > +	} else {
> > > +		 if (idx < snd_ecards_limit) {
> > > +			if (snd_cards_lock & (1 << idx))
> > > +				err = -EBUSY;	/* invalid */
> > > +		} else if (idx < SNDRV_CARDS)
> > > +				snd_ecards_limit = idx + 1; /* increase the limit */
> > > +			else
> > > +				err = -ENODEV;
> > 
> > The indent looks strange in the above three lines.
> > Also, for me it's not much better than before... :)
> > (all if's are comparisons of idx with other values.)
> 
> Hi,
> 
> OK, how about this one? The original indentation makes the control
> flow very hard to follow.
> 
> 	Regards
> 		Oliver
> 
> Signed-off-by: Oliver Neukum <oneukum@suse.de>

Thanks, now applied to ALSA tree.


Takashi