mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Meelis Roos <mroos@linux.ee>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: ALSA bt87x compile failure in 2.6.13-rc3
Date: Wed, 06 Jul 2005 12:13:50 +0200	[thread overview]
Message-ID: <s5hekacdyxt.wl%tiwai@suse.de> (raw)
In-Reply-To: <Pine.SOC.4.61.0507060925010.22423@math.ut.ee>

At Wed, 6 Jul 2005 09:27:36 +0300 (EEST),
Meelis Roos wrote:
> 
>    CC [M]  sound/pci/bt87x.o
> sound/pci/bt87x.c: In function `snd_bt87x_detect_card':
> sound/pci/bt87x.c:807: error: `driver' undeclared (first use in this function)
> sound/pci/bt87x.c:807: error: (Each undeclared identifier is reported only once
> sound/pci/bt87x.c:807: error: for each function it appears in.)
> sound/pci/bt87x.c: At top level:
> sound/pci/bt87x.c:910: error: `driver' used prior to declaration
> make[2]: *** [sound/pci/bt87x.o] Error 1
> 
> Substituting driver with pci->driver seems to cure it, it this the 
> correct fix?

The below one-liner should fix.


Takashi

----
[ALSA] Fix the compilation of bt87x.c

Use pci_match_id() function instead of pci_match_device() to compile
properly.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/pci/bt87x.c b/sound/pci/bt87x.c
--- a/sound/pci/bt87x.c
+++ b/sound/pci/bt87x.c
@@ -804,7 +804,7 @@ static int __devinit snd_bt87x_detect_ca
 	int i;
 	const struct pci_device_id *supported;
 
-	supported = pci_match_device(driver, pci);
+	supported = pci_match_id(snd_bt87x_ids, pci);
 	if (supported)
 		return supported->driver_data;
 

      parent reply	other threads:[~2005-07-06 14:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-06  6:27 Meelis Roos
2005-07-06  8:42 ` Meelis Roos
2005-07-06 10:13 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hekacdyxt.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®