From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EECD4C433EF for ; Thu, 7 Apr 2022 08:29:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243013AbiDGIbZ (ORCPT ); Thu, 7 Apr 2022 04:31:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242994AbiDGIbS (ORCPT ); Thu, 7 Apr 2022 04:31:18 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7353C4E13 for ; Thu, 7 Apr 2022 01:29:19 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 63AFA21117; Thu, 7 Apr 2022 08:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1649320158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qiMMcbgbBUNCl5v74qCWUJz7Rx460O5aMRrz4d3d/Os=; b=QN+J2jesQwcpmA8WQ30ocJSLuwPomgNuIKm7afkyfyJuaSaCNgxfxbKJgFExCtjXOeIumK YFi7qP3HbWyzR7PF1RevbDhqW5fMXAVF5P10+zR1T9K+qbgWbpkHenLT9Dc6tNXmKv7KBK P0o1iOpTV/EXB5G1yPtzj5hYOOqWtEs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1649320158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qiMMcbgbBUNCl5v74qCWUJz7Rx460O5aMRrz4d3d/Os=; b=yVktQ/JvhOMsUPyWxOKGdCvChgSlaAKm0Me/cywl+hfAKNMzomcG+gc2LetawRRUAqJujD uAzc6VVKBRp9eRDQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id ED8A0A3B96; Thu, 7 Apr 2022 08:29:13 +0000 (UTC) Date: Thu, 07 Apr 2022 10:29:18 +0200 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Geert Uytterhoeven , kernel test robot , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Subject: Re: [PATCH v3] sound/oss/dmasound: fix build when drivers are mixed =y/=m In-Reply-To: <20220405234118.24830-1-rdunlap@infradead.org> References: <20220405234118.24830-1-rdunlap@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 06 Apr 2022 01:41:18 +0200, Randy Dunlap wrote: > > When CONFIG_DMASOUND_ATARI=m and CONFIG_DMASOUND_Q40=y (or vice versa), > dmasound_core.o can be built without dmasound_deinit() being defined, > causing a build error: > > ERROR: modpost: "dmasound_deinit" [sound/oss/dmasound/dmasound_atari.ko] undefined! > > Modify dmasound_core.c and dmasound.h so that dmasound_deinit() is > always available. > > The mixed modes (=y/=m) also mean that several variables and structs > have to be declared in all cases. > > Suggested-by: Arnd Bergmann > Suggested-by: Geert Uytterhoeven > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Link: lore.kernel.org/r/202204032138.EFT9qGEd-lkp@intel.com > Cc: Geert Uytterhoeven > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: alsa-devel@alsa-project.org Thanks, applied now. Takashi