From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 9474DC433FE
	for <linux-kernel@archiver.kernel.org>; Fri, 14 Jan 2022 16:15:34 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S243215AbiANQPd (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 14 Jan 2022 11:15:33 -0500
Received: from smtp-out2.suse.de ([195.135.220.29]:52774 "EHLO
        smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S243170AbiANQPc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 Jan 2022 11:15:32 -0500
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out2.suse.de (Postfix) with ESMTP id 8B1571F45F;
        Fri, 14 Jan 2022 16:15:31 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1642176931; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=R1DfE0qZS3U7n7IbaGCVpvPLTKsF+WfRR2YH34S4yhI=;
        b=rc9oJsiZrlzZzou7u13kVvTPHtBWIqfPefVi+l7JerRw0NBUGcqS5OcEsSF1a0Re8W1bfe
        TwPbIOr5QHeY7peBxKt+bTdkre88kFGBaXXYd5LFnzNj3g+MluGFnRaNLfNhPxmBk8vAGq
        IBKrTA+EbnGUwNijT+zzaMTXxkw5MZI=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1642176931;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=R1DfE0qZS3U7n7IbaGCVpvPLTKsF+WfRR2YH34S4yhI=;
        b=0XG4sNPZn2Hx45cPbMHI2BGvPyp+Zgn6QS8/280F9pmWynAMcZjyK0gFz3AU3XpJ30bX5e
        0cshHh+ZjDLG/TAQ==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 772D2A3B87;
        Fri, 14 Jan 2022 16:15:31 +0000 (UTC)
Date:   Fri, 14 Jan 2022 17:15:31 +0100
Message-ID: <s5hfspq47ks.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Lucas Tanure <tanureal@opensource.cirrus.com>
Cc:     "Rafael J . Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
        <linux-acpi@vger.kernel.org>, <patches@opensource.cirrus.com>,
        <platform-driver-x86@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] ALSA: hda: cs35l41: Tidyup code and add default cases
In-Reply-To: <20220113170728.1953559-4-tanureal@opensource.cirrus.com>
References: <20220113170728.1953559-1-tanureal@opensource.cirrus.com>
        <20220113170728.1953559-4-tanureal@opensource.cirrus.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 13 Jan 2022 18:07:27 +0100,
Lucas Tanure wrote:
> 
> Clean up the code, plus adding default cases for switch
> and dev_err_probe use.

Please split to patches.  There are too much mixed up of changes for
different goals.  There is difference between a white-space cleanup or
such (that is, no significant change of the resultant binary), a
cleanup with a better API usage, and a code refactoring.  And, the
addition of the missing default case is rather the fix, not a clean
up...


thanks,

Takashi