From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC969C2BA19 for ; Tue, 21 Apr 2020 06:06:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DDD32076C for ; Tue, 21 Apr 2020 06:06:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726364AbgDUGGf (ORCPT ); Tue, 21 Apr 2020 02:06:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:46398 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725902AbgDUGGe (ORCPT ); Tue, 21 Apr 2020 02:06:34 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9EEF0AA55; Tue, 21 Apr 2020 06:06:32 +0000 (UTC) Date: Tue, 21 Apr 2020 08:06:32 +0200 Message-ID: From: Takashi Iwai To: Gregor Pintar Cc: tiwai@suse.com, perex@perex.cz, alexander@tsoy.me, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2] ALSA: usb-audio: Add quirk for Focusrite Scarlett 2i2 In-Reply-To: <20200420214030.2361-1-grpintar@gmail.com> References: <1c4b8a362761421eba0ded60bb4f0e11b7e42f3b.camel@tsoy.me> <20200420214030.2361-1-grpintar@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Apr 2020 23:40:30 +0200, Gregor Pintar wrote: > > Force it to use asynchronous playback. > > Same quirk has already been added for Focusrite Scarlett Solo (2nd gen) > with a commit 46f5710f0b88 ("ALSA: usb-audio: Add quirk for Focusrite > Scarlett Solo"). > > This also seems to prevent regular clicks when playing at 44100Hz > on Scarlett 2i2 (2nd gen). I did not notice any side effects. > > Moved both quirks to snd_usb_audioformat_attributes_quirk() as suggested. > > Signed-off-by: Gregor Pintar Applied it now to for-linus branch. thanks, Takashi