From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=WVJ0=YK=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 073E5FA372D
	for <linux-kernel@archiver.kernel.org>; Thu, 17 Oct 2019 08:19:50 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id D78A520820
	for <linux-kernel@archiver.kernel.org>; Thu, 17 Oct 2019 08:19:49 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2405146AbfJQITs (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 17 Oct 2019 04:19:48 -0400
Received: from mx2.suse.de ([195.135.220.15]:39074 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S2389530AbfJQITs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 17 Oct 2019 04:19:48 -0400
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.220.254])
        by mx1.suse.de (Postfix) with ESMTP id F2490B2FD;
        Thu, 17 Oct 2019 08:19:45 +0000 (UTC)
Date:   Thu, 17 Oct 2019 10:19:45 +0200
Message-ID: <s5hftjriy1q.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Szabolcs =?UTF-8?B?U3rFkWtl?= <szszoke.code@gmail.com>
Cc:     <alsa-devel@alsa-project.org>,
        "Manuel Reinhardt" <manuel.rhdt@gmail.com>,
        "Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
        "Shuah Khan" <shuah@kernel.org>, "Ard van Breemen" <ard@kwaak.net>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        "Jaroslav Kysela" <perex@perex.cz>,
        "Richard Fontana" <rfontana@redhat.com>,
        "Takashi Iwai" <tiwai@suse.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Disable quirks for BOSS Katana amplifiers
In-Reply-To: <20191011171937.8013-1-szszoke.code@gmail.com>
References: <20191011171937.8013-1-szszoke.code@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 11 Oct 2019 19:19:36 +0200,
Szabolcs Szőke wrote:
> 
> BOSS Katana amplifiers cannot be used for recording or playback if quirks
> are applied
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=195223
> Signed-off-by: Szabolcs Szőke <szszoke.code@gmail.com>

Applied now.  Thanks.


Takashi

> 
> ---
>  sound/usb/pcm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index 33cd26763c0e..daadb0c66eee 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -348,6 +348,9 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
>  		ep = 0x84;
>  		ifnum = 0;
>  		goto add_sync_ep_from_ifnum;
> +	case USB_ID(0x0582, 0x01d8): /* BOSS Katana */
> +		/* BOSS Katana amplifiers do not need quirks */
> +		return 0;
>  	}
>  
>  	if (attr == USB_ENDPOINT_SYNC_ASYNC &&
> -- 
> 2.20.1
>