From: Takashi Iwai <tiwai@suse.de>
To: "Jia-Ju Bai" <baijiaju1990@gmail.com>
Cc: <tglx@linutronix.de>, <gregkh@linuxfoundation.org>,
<perex@perex.cz>, <rfontana@redhat.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()
Date: Fri, 26 Jul 2019 14:26:31 +0200 [thread overview]
Message-ID: <s5hftmtyoaw.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190726021442.21177-1-baijiaju1990@gmail.com>
On Fri, 26 Jul 2019 04:14:42 +0200,
Jia-Ju Bai wrote:
>
> In build_adc_controls(), there is an if statement on line 773 to check
> whether ak->adc_info is NULL:
> if (! ak->adc_info ||
> ! ak->adc_info[mixer_ch].switch_name)
>
> When ak->adc_info is NULL, it is used on line 792:
> knew.name = ak->adc_info[mixer_ch].selector_name;
>
> Thus, a possible null-pointer dereference may occur.
>
> To fix this bug, referring to lines 773 and 774, ak->adc_info
> and ak->adc_info[mixer_ch].selector_name are checked before being used.
>
> This bug is found by a static analysis tool STCheck written by us.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Applied, thanks.
Takashi
prev parent reply other threads:[~2019-07-26 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 2:14 Jia-Ju Bai
2019-07-26 12:26 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hftmtyoaw.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=baijiaju1990@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rfontana@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®