From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752731AbeC0Ppt (ORCPT <rfc822;w@1wt.eu>);
        Tue, 27 Mar 2018 11:45:49 -0400
Received: from mx2.suse.de ([195.135.220.15]:52787 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752508AbeC0Pps (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Mar 2018 11:45:48 -0400
Date: Tue, 27 Mar 2018 17:45:46 +0200
Message-ID: <s5hfu4l8qtx.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Colin King" <colin.king@canonical.com>
Cc: <alsa-devel@alsa-project.org>, "Andrew Chant" <achant@google.com>,
        "Jaroslav Kysela" <perex@perex.cz>, <kernel-janitors@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: fix memory leak on cval
In-Reply-To: <20180327143001.13870-1-colin.king@canonical.com>
References: <20180327143001.13870-1-colin.king@canonical.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 27 Mar 2018 16:30:01 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> With the current exit return path of the ctl_info allocation failure
> cval is not being freed resulting in a memory leak. Fix this by kfree'ing
> it on the return.
> 
> Detected by CoverityScan, CID#1466878 ("Resource Leak")
> 
> Fixes: 21e9b3e931f7 ("ALSA: usb-audio: fix uac control query argument")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, applied now.


Takashi