From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751407AbdDAIq7 (ORCPT ); Sat, 1 Apr 2017 04:46:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:39145 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750924AbdDAIq4 (ORCPT ); Sat, 1 Apr 2017 04:46:56 -0400 Date: Sat, 01 Apr 2017 10:46:53 +0200 Message-ID: From: Takashi Iwai To: "Matthias Kaehlcke" Cc: "Julia Lawall" , "Jaroslav Kysela" , "Sven Hahne" , , "Grant Grundler" , "Greg Hackmann" , "Michael Davidson" , Subject: Re: [PATCH v2] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit In-Reply-To: <20170401010005.90685-1-mka@chromium.org> References: <20170401010005.90685-1-mka@chromium.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 01 Apr 2017 03:00:04 +0200, Matthias Kaehlcke wrote: > > With the previous unsigned long value clang generates warnings like > this: > > sound/pci/hda/patch_ca0132.c:860:37: error: implicit conversion from > 'unsigned long' to 'u32' (aka 'unsigned int') changes value from > 18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion] > spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx; > ~ ^~~~ > > Signed-off-by: Matthias Kaehlcke Thanks, applied. Takashi > --- > Changes in v2: > - Remove unnecessary cast to u32 > > sound/pci/hda/patch_ca0132.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c > index 07a9deb17477..2023fe472be1 100644 > --- a/sound/pci/hda/patch_ca0132.c > +++ b/sound/pci/hda/patch_ca0132.c > @@ -857,7 +857,7 @@ static int chipio_write_address(struct hda_codec *codec, > chip_addx >> 16); > } > > - spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx; > + spec->curr_chip_addx = (res < 0) ? ~0U : chip_addx; > > return res; > } > @@ -882,7 +882,7 @@ static int chipio_write_data(struct hda_codec *codec, unsigned int data) > /*If no error encountered, automatically increment the address > as per chip behaviour*/ > spec->curr_chip_addx = (res != -EIO) ? > - (spec->curr_chip_addx + 4) : ~0UL; > + (spec->curr_chip_addx + 4) : ~0U; > return res; > } > > @@ -933,7 +933,7 @@ static int chipio_read_data(struct hda_codec *codec, unsigned int *data) > /*If no error encountered, automatically increment the address > as per chip behaviour*/ > spec->curr_chip_addx = (res != -EIO) ? > - (spec->curr_chip_addx + 4) : ~0UL; > + (spec->curr_chip_addx + 4) : ~0U; > return res; > } > > -- > 2.12.2.564.g063fe858b8-goog > >