mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Takashi Sakamoto" <o-takashi@sakamocchi.jp>
Cc: <alsa-devel@alsa-project.org>,
	"Satendra Singh Thakur" <satendra.t@samsung.com>,
	<perex@perex.cz>, <hemanshu.s@samsung.com>,
	<nishant.s4@samsung.com>, <ycheon.song@samsung.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [RFC] [ALSA][CONTROL] Added 2 ioctls for reading/writing values of multiple controls in one go (at once)
Date: Fri, 03 Feb 2017 08:24:28 +0100	[thread overview]
Message-ID: <s5hfujvivo3.wl-tiwai@suse.de> (raw)
In-Reply-To: <a68d296b-9f31-51e1-357c-d75e90b24420@sakamocchi.jp>

On Thu, 02 Feb 2017 04:45:48 +0100,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Feb 2 2017 12:14, Satendra Singh Thakur wrote:
> > From: satendra singh thakur <satendra.t@samsung.com>
> >
> > -Added 2 ioctls in alsa driver's control interface
> > -Added an ioctl to read values of multiple elements at once
> > -Added an ioctl to write values of multiple elements at once
> > -In the absence of above ioctls user needs to call N ioctls to
> >  read/write value of N elements which requires N context switches
> > -Proposed ioctls will allow accessing N elements' values in a single
> >  context switch
> > -Above mentioned ioctl will be useful for alsa utils such as amixer
> >  which reads all controls of given sound card
> >
> > Signed-off-by: Satendra Singh Thakur <satendra.t@samsung.com>
> > ---
> >  include/uapi/sound/asound.h |    8 +++++
> >  sound/core/control.c        |   69 +++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 77 insertions(+)
> 
> I'm _strongly_ interested in your two patches, because it has a
> potentiality to purge ASoC abuse of TLV feature, which was introduced
> in  2014 with a bad reviewing process.

I don't think it can be a replacement for the extended TLV usages.
The proposed API is nothing but a loop of ctl elem read/write, and I'm
not sure whether it worth to introduce the new ioctls just for that.


Takashi

  reply	other threads:[~2017-02-03  7:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170202031525epcas1p2164b4ca25afe9fb5cd418d004da961f5@epcas1p2.samsung.com>
2017-02-02  3:14 ` Satendra Singh Thakur
2017-02-02  3:45   ` Takashi Sakamoto
2017-02-03  7:24     ` Takashi Iwai [this message]
2017-02-02 17:22   ` [alsa-devel] " Clemens Ladisch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hfujvivo3.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=hemanshu.s@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nishant.s4@samsung.com \
    --cc=o-takashi@sakamocchi.jp \
    --cc=perex@perex.cz \
    --cc=satendra.t@samsung.com \
    --cc=ycheon.song@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®