From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753316AbbIDKOX (ORCPT <rfc822;w@1wt.eu>);
	Fri, 4 Sep 2015 06:14:23 -0400
Received: from mx2.suse.de ([195.135.220.15]:50445 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750937AbbIDKOV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 4 Sep 2015 06:14:21 -0400
Date: Fri, 04 Sep 2015 12:14:18 +0200
Message-ID: <s5hfv2ujxtx.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Luis de Bethencourt" <luis@debethencourt.com>
Cc: <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
        "Javier Martinez Canillas" <javier@osg.samsung.com>,
        "Jaroslav Kysela" <perex@perex.cz>, "Wolfram Sang" <wsa@the-dreams.de>,
        "Christophe JAILLET" <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] ALSA: sparc: amd7930: Fix module autoload for OF platform driver
In-Reply-To: <20150903110304.GA17142@goodgumbo.baconseed.org>
References: <20150903110304.GA17142@goodgumbo.baconseed.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 03 Sep 2015 13:03:04 +0200,
Luis de Bethencourt wrote:
> 
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>

Applied, thanks.


Takashi

> ---
> 
> Hello,
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to eport
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> 
> Thanks,
> Luis
> 
>  sound/sparc/amd7930.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/sparc/amd7930.c b/sound/sparc/amd7930.c
> index 784ceb8..35c1f6a 100644
> --- a/sound/sparc/amd7930.c
> +++ b/sound/sparc/amd7930.c
> @@ -1064,6 +1064,7 @@ static const struct of_device_id amd7930_match[] = {
>  	},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, amd7930_match);
>  
>  static struct platform_driver amd7930_sbus_driver = {
>  	.driver = {
> -- 
> 2.4.6
> 
>