From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752728AbbERI3V (ORCPT ); Mon, 18 May 2015 04:29:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46627 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750958AbbERI3M (ORCPT ); Mon, 18 May 2015 04:29:12 -0400 Date: Mon, 18 May 2015 10:29:10 +0200 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: oss: fix build warning In-Reply-To: <1431601979-24852-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1431601979-24852-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 14 May 2015 16:42:59 +0530, Sudip Mukherjee wrote: > > while building with allyesconfig it was giving a build warning about > unused variable. declare the variable only if the driver is built as a > module. > > Signed-off-by: Sudip Mukherjee Ideally it'd be better to convert to use isapnp_device_id table directly, but this code is a bit tricky (YMH0021 isn't exposed as a probe id), so I applied your patch as is. thanks, Takashi > --- > > build tested with allyesconfig and allmodconfig > > sound/oss/ad1848.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/oss/ad1848.c b/sound/oss/ad1848.c > index ec1ee07..10c8de1 100644 > --- a/sound/oss/ad1848.c > +++ b/sound/oss/ad1848.c > @@ -2860,6 +2860,7 @@ static struct { > {NULL} > }; > > +#ifdef MODULE > static struct isapnp_device_id id_table[] = { > { ISAPNP_VENDOR('C','M','I'), ISAPNP_DEVICE(0x0001), > ISAPNP_VENDOR('@','@','@'), ISAPNP_FUNCTION(0x0001), 0 }, > @@ -2877,6 +2878,7 @@ static struct isapnp_device_id id_table[] = { > }; > > MODULE_DEVICE_TABLE(isapnp, id_table); > +#endif > > static struct pnp_dev *activate_dev(char *devname, char *resname, struct pnp_dev *dev) > { > -- > 1.8.1.2 >