From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751722AbbAKUcP (ORCPT ); Sun, 11 Jan 2015 15:32:15 -0500 Received: from cantor2.suse.de ([195.135.220.15]:37316 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753AbbAKUcO (ORCPT ); Sun, 11 Jan 2015 15:32:14 -0500 Date: Sun, 11 Jan 2015 21:32:12 +0100 Message-ID: From: Takashi Iwai To: Josh Triplett Cc: Rickard Strandqvist , Jaroslav Kysela , Maxime Ripard , Rashika Kheria , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: lx6464es: lx_core: Remove some unused functions In-Reply-To: <20150111201806.GA1074@thin> References: <1420990982-20187-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <20150111201806.GA1074@thin> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 11 Jan 2015 12:18:06 -0800, Josh Triplett wrote: > > On Sun, Jan 11, 2015 at 04:55:23PM +0100, Takashi Iwai wrote: > > At Sun, 11 Jan 2015 16:43:02 +0100, > > Rickard Strandqvist wrote: > > > > > > Removes some functions that are not used anywhere: > > > lx_buffer_cancel() lx_buffer_free() lx_stream_sample_position() > > > lx_stream_state() lx_pipe_sample_count() > > > > We really shouldn't delete the code but keep somehow disabled for such > > a driver that has no hardware spec documents available. Since the > > source code is the only reference, the implemented code is the only > > information if we need to change / fix anything. > > Easy enough to get it back out of version control if so. It's far difficult to find out the information. Takashi