From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758735AbaDBMmK (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Apr 2014 08:42:10 -0400
Received: from cantor2.suse.de ([195.135.220.15]:38016 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758575AbaDBMmI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Apr 2014 08:42:08 -0400
Date: Wed, 02 Apr 2014 14:42:07 +0200
Message-ID: <s5hfvlvucm8.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Jean Delvare <jdelvare@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Struan Bartlett <struan.bartlett@gmail.com>,
        Andreas Schwab <schwab@linux-m68k.org>, gnomes@lxorguk.ukuu.org.uk,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ttyprintk: Allow built as a module
In-Reply-To: <1396441906.28124.3.camel@chaos.site>
References: <1396434582-30799-1-git-send-email-tiwai@suse.de>
	<1396434582-30799-2-git-send-email-tiwai@suse.de>
	<1396441906.28124.3.camel@chaos.site>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 02 Apr 2014 14:31:46 +0200,
Jean Delvare wrote:
> 
> Hi Takashi,
> 
> Le Wednesday 02 April 2014 à 12:29 +0200, Takashi Iwai a écrit :
> > The driver is well written to be used as a module, just the exit call
> > is missing.
> > 
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> >  drivers/char/Kconfig     |  2 +-
> >  drivers/char/ttyprintk.c | 13 ++++++++++++-
> >  2 files changed, 13 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> > index 1386749b48ff..97816b133c7f 100644
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig
> > @@ -40,7 +40,7 @@ config SGI_MBCS
> >  source "drivers/tty/serial/Kconfig"
> >  
> >  config TTY_PRINTK
> > -	bool "TTY driver to output user messages via printk"
> > +	tristate "TTY driver to output user messages via printk"
> >  	depends on EXPERT && TTY
> >  	default n
> >  	---help---
> > diff --git a/drivers/char/ttyprintk.c b/drivers/char/ttyprintk.c
> > index 2a39c5790364..73606eaaba71 100644
> > --- a/drivers/char/ttyprintk.c
> > +++ b/drivers/char/ttyprintk.c
> > @@ -17,7 +17,7 @@
> >  #include <linux/device.h>
> >  #include <linux/serial.h>
> >  #include <linux/tty.h>
> > -#include <linux/export.h>
> > +#include <linux/module.h>
> >  
> >  struct ttyprintk_port {
> >  	struct tty_port port;
> > @@ -214,4 +214,15 @@ error:
> >  	tty_port_destroy(&tpk_port.port);
> >  	return ret;
> >  }
> > +
> > +static void ttyprintk_exit(void)
> 
> Could be marked __exit.
> 
> > +{
> > +	tty_unregister_driver(ttyprintk_driver);
> > +	put_tty_driver(ttyprintk_driver);
> > +	tty_port_destroy(&tpk_port.port);
> > +}
> > +
> >  device_initcall(ttyprintk_init);
> > +module_exit(ttyprintk_exit);
> > +
> > +MODULE_LICENSE("GPL");
> 
> Other than this, this looks good, thanks for doing that.
> 
> Reviewed-by: Jean Delvare <jdelvare@suse.de>

Thanks!  I'll resubmit the fixed patch.


Takashi