From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754813Ab2GCJUq (ORCPT ); Tue, 3 Jul 2012 05:20:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55580 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753150Ab2GCJUo (ORCPT ); Tue, 3 Jul 2012 05:20:44 -0400 Date: Tue, 03 Jul 2012 11:20:41 +0200 Message-ID: From: Takashi Iwai To: Adam Jackson Cc: Sven Joachim , dri-devel@lists.freedesktop.org, Rodrigo Vivi , Dave Airlie , linux-kernel@vger.kernel.org Subject: Re: Bogus video resolution in Linux 3.5-rc4 In-Reply-To: <4FF1FA95.7000404@redhat.com> References: <874npzebev.fsf@turtle.gmx.de> <87obo7jnmn.fsf@turtle.gmx.de> <87r4t3w59r.fsf@turtle.gmx.de> <4FF1FA95.7000404@redhat.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 02 Jul 2012 15:46:29 -0400, Adam Jackson wrote: > > On 6/26/12 3:21 AM, Takashi Iwai wrote: > > > From: Takashi Iwai > > Subject: [PATCH] drm: edid: Don't add inferred modes with higher resolution > > > > When a monitor EDID doesn't give the preferred bit, driver assumes > > that the mode with the higest resolution and rate is the preferred > > mode. Meanwhile the recent changes for allowing more modes in the > > GFT/CVT ranges give actually more modes, and some modes may be over > > the native size. Thus such a mode would be picked up as the preferred > > mode although it's no native resolution. > > > > For avoiding such a problem, this patch limits the addition of > > inferred modes by checking not to be greater than other modes. > > Also, it checks the duplicated mode entry at the same time. > > This is a little aggressive on CRTs, but whatever, better than what's there. > > Reviewed-by: Adam Jackson Thanks. I'm going to resend the patch with your tag. Takashi