From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755496Ab1ILL6s (ORCPT ); Mon, 12 Sep 2011 07:58:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44855 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755252Ab1ILL6r (ORCPT ); Mon, 12 Sep 2011 07:58:47 -0400 Date: Mon, 12 Sep 2011 13:58:46 +0200 Message-ID: From: Takashi Iwai To: Axel Lin Cc: linux-kernel@vger.kernel.org, Wolfram Sang , Jaroslav Kysela , alsa-devel@alsa-project.org Subject: Re: [PATCH 2/2] ALSA: keywest: Remove obsolete cleanup for clientdata In-Reply-To: <1315561852.2831.1.camel@phoenix> References: <1315561784.2831.0.camel@phoenix> <1315561852.2831.1.camel@phoenix> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 09 Sep 2011 17:50:52 +0800, Axel Lin wrote: > > The i2c core will clear the clientdata pointer automatically. > We don't have to set the `data' field to NULL in remove() or > if probe() failed anymore. > > Signed-off-by: Axel Lin Applied now. Thanks. Takashi > --- > sound/ppc/keywest.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/sound/ppc/keywest.c b/sound/ppc/keywest.c > index 8f064c7..4080bec 100644 > --- a/sound/ppc/keywest.c > +++ b/sound/ppc/keywest.c > @@ -82,7 +82,6 @@ static int keywest_attach_adapter(struct i2c_adapter *adapter) > > static int keywest_remove(struct i2c_client *client) > { > - i2c_set_clientdata(client, NULL); > if (! keywest_ctx) > return 0; > if (client == keywest_ctx->client) > -- > 1.7.4.1 > > >