From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754030Ab1ENKBQ (ORCPT ); Sat, 14 May 2011 06:01:16 -0400 Received: from cantor.suse.de ([195.135.220.2]:41221 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751899Ab1ENKBP (ORCPT ); Sat, 14 May 2011 06:01:15 -0400 Date: Sat, 14 May 2011 12:01:12 +0200 Message-ID: From: Takashi Iwai To: Ondrej Zary Cc: linux-media@vger.kernel.org, alsa-devel@alsa-project.org, Kernel development list Subject: Re: [alsa-devel] [PATCH RFC] radio-sf16fmr2: convert to generic TEA575x interface In-Reply-To: <201105140017.26968.linux@rainbow-software.org> References: <201105140017.26968.linux@rainbow-software.org> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sat, 14 May 2011 00:17:23 +0200, Ondrej Zary wrote: > > Hello, > the SF16-FMR2 radio card is basically a TEA5757 tuner connected to ISA bus but > the driver currently uses its own implementation. I converted the driver to > use generic tea575x-tuner implementation (see patch below) and it works fine. > > But the tea575x-tuner module is located in /sound/i2c/other and the > corresponding Kconfig in /sound/pci. Should it be moved > to /drivers/media/radio or better leave it as is? That would be a feasible option. Actually no ALSA-specific data / function is used in tea575x-tuner.c, so it'd be more natural to put it to drivers/media/radio. (And remove the inclusion of from relevant files.) thanks, Takashi