From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753425AbZHTK7s (ORCPT ); Thu, 20 Aug 2009 06:59:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752334AbZHTK7r (ORCPT ); Thu, 20 Aug 2009 06:59:47 -0400 Received: from cantor.suse.de ([195.135.220.2]:52885 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567AbZHTK7q (ORCPT ); Thu, 20 Aug 2009 06:59:46 -0400 Date: Thu, 20 Aug 2009 12:59:46 +0200 Message-ID: From: Takashi Iwai To: Hannes Reinecke Cc: Andrew Morton , Sam Ravnborg , Linux Kernel , Ingo Molnar , "H. Peter Anvin" , Jeremy Fitzhardinge , stable@kernel.org Subject: Re: [REGRESSION] _end symbol missing from Symbol.map In-Reply-To: <4A8CE63E.9050702@suse.de> References: <4A83B680.5000508@suse.de> <20090819093704.f1620baa.akpm@linux-foundation.org> <4A8CE63E.9050702@suse.de> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 20 Aug 2009 07:59:26 +0200, Hannes Reinecke wrote: > > Andrew Morton wrote: > > On Thu, 13 Aug 2009 08:45:20 +0200 Hannes Reinecke wrote: > > > >> Hi all, > >> > >> with 2.6.31 'crash' on x86_64 falls flat on its face as the '_end' symbol > >> is missing from the System.map file. > >> > >> The culprit is commit 091e52c3551d3031343df24b573b770b4c6c72b6, > >> which moved the '_end' symbol into it's own section. > >> Apparently this causes kallsyms to not reference it properly. > >> > >> So either we'd need to revert part of the patch to not > >> include _end in it's own section: > >> > >> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S > >> index 59f31d2..1422df5 100644 > >> --- a/arch/x86/kernel/vmlinux.lds.S > >> +++ b/arch/x86/kernel/vmlinux.lds.S > >> @@ -376,9 +376,7 @@ SECTIONS > >> __brk_limit = .; > >> } > >> > >> - .end : AT(ADDR(.end) - LOAD_OFFSET) { > >> - _end = .; > >> - } > >> + _end = .; > >> > >> /* Sections to be discarded */ > >> /DISCARD/ : { > >> > >> or someone has to fixup kallsyms. But this is far beyond my comfort zone. > >> > > > > So System.map is part of the kernel API too? Sigh. > > > > Your email client replaces tabs with spaces. > > > I know. > > > The patch didn't have a signed-off-by: > > > I know, too. > However, this is clearly a band-aid, and as such I reported > it more as an RFC. > One (Sam?) should really fix up kallsyms to extract the _end symbol. > Hence I didn't warrant it with a Signed-off line. > > > I queued it up, and tagged it for -stable backporting. Unless we come > > up with something better. > > > I was sort of hoping Sam would speak up and present some better approach ... > > > We might not get this into 2.6.31, in which case this fix or its > > replacement will need backporting to 2.6.30.x and 2.6.31.x (IMO). Yep, x86-32 had already the own end section in 2.6.30 kernel, which was introduced by the following commit: commit 0a699af8e613a670be50245366fa18cb19ac5172 Author: H. Peter Anvin Date: Tue Mar 17 14:14:31 2009 -0700 x86-32: move _end to a dummy section Impact: build fix with CONFIG_RELOCATABLE Move _end into a dummy section, so that relocs.c will know it is a relocatable symbol. Signed-off-by: H. Peter Anvin Cc: Jeremy Fitzhardinge Cc: Jeremy Fitzhardinge So, judging from the commit log, simply reverting it seems to have some drawback...? thanks, Takashi