From: Takashi Iwai <tiwai@suse.de>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: cs8427.c use put_unaligned helper
Date: Thu, 08 May 2008 15:40:15 +0200 [thread overview]
Message-ID: <s5hfxssykw0.wl%tiwai@suse.de> (raw)
In-Reply-To: <1210190367.19279.45.camel@brick>
At Wed, 07 May 2008 12:59:27 -0700,
Harvey Harrison wrote:
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Thanks, applied to ALSA tree.
Takashi
> ---
> sound/i2c/cs8427.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/sound/i2c/cs8427.c b/sound/i2c/cs8427.c
> index e57e9cb..9c3d361 100644
> --- a/sound/i2c/cs8427.c
> +++ b/sound/i2c/cs8427.c
> @@ -23,6 +23,7 @@
> #include <linux/slab.h>
> #include <linux/delay.h>
> #include <linux/init.h>
> +#include <asm/unaligned.h>
> #include <sound/core.h>
> #include <sound/control.h>
> #include <sound/pcm.h>
> @@ -264,10 +265,7 @@ int snd_cs8427_create(struct snd_i2c_bus *bus,
> goto __fail;
> }
> /* write default channel status bytes */
> - buf[0] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 0));
> - buf[1] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 8));
> - buf[2] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 16));
> - buf[3] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 24));
> + put_unaligned_le32(SNDRV_PCM_DEFAULT_CON_SPDIF, buf);
> memset(buf + 4, 0, 24 - 4);
> if (snd_cs8427_send_corudata(device, 0, buf, 24) < 0)
> goto __fail;
> --
> 1.5.5.1.404.g981f6
>
>
>
prev parent reply other threads:[~2008-05-08 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 19:59 Harvey Harrison
2008-05-08 13:40 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hfxssykw0.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®