From: Takashi Iwai <tiwai@suse.de>
To: Eugene Teo <eugene.teo@eugeneteo.net>
Cc: linux-kernel@vger.kernel.org,
Frank van de Pol <fvdpol@coil.demon.nl>,
Jaroslav Kysela <perex@suse.cz>, Takashi Iwai <tiwai@suse.de>
Subject: Re: Fix seq_clientmgr dereferences before NULL check
Date: Thu, 16 Mar 2006 11:56:57 +0100 [thread overview]
Message-ID: <s5hfylir72e.wl%tiwai@suse.de> (raw)
In-Reply-To: <20060316014606.GA20609@eugeneteo.net>
At Thu, 16 Mar 2006 09:46:06 +0800,
Eugene Teo wrote:
>
> Fix cptr->pool dereferences before NULL check.
cptr->pool must be non-NULL there, so just the if (cptr->pool) is
superfluous.
Takashi
> Coverity bug #860
>
> Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
>
> --- linux-2.6/sound/core/seq/seq_clientmgr.c~ 2006-03-15 10:05:45.000000000 +0800
> +++ linux-2.6/sound/core/seq/seq_clientmgr.c 2006-03-16 09:41:05.000000000 +0800
> @@ -1862,12 +1862,13 @@
> cptr = snd_seq_client_use_ptr(info.client);
> if (cptr == NULL)
> return -ENOENT;
> + if (cptr->pool == NULL)
> + return -ENOENT;
> memset(&info, 0, sizeof(info));
> info.output_pool = cptr->pool->size;
> info.output_room = cptr->pool->room;
> info.output_free = info.output_pool;
> - if (cptr->pool)
> - info.output_free = snd_seq_unused_cells(cptr->pool);
> + info.output_free = snd_seq_unused_cells(cptr->pool);
> if (cptr->type == USER_CLIENT) {
> info.input_pool = cptr->data.user.fifo_pool_size;
> info.input_free = info.input_pool;
>
> --
> 1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80
> main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2006-03-16 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 1:46 Eugene Teo
2006-03-16 10:56 ` Takashi Iwai [this message]
2006-03-16 12:17 ` Eugene Teo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hfylir72e.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=eugene.teo@eugeneteo.net \
--cc=fvdpol@coil.demon.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®