From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S261780AbVGGUBN@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S261780AbVGGUBN (ORCPT <rfc822;willy@w.ods.org>);
	Thu, 7 Jul 2005 16:01:13 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262074AbVGGT6q
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 7 Jul 2005 15:58:46 -0400
Received: from cantor2.suse.de ([195.135.220.15]:30173 "EHLO mx2.suse.de")
	by vger.kernel.org with ESMTP id S262316AbVGGT5r (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Jul 2005 15:57:47 -0400
Date: Thu, 07 Jul 2005 21:57:39 +0200
Message-ID: <s5hfyuq9yoc.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Greg KH <greg@kroah.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Eyal Lebedinsky <eyal@eyal.emu.id.au>,
       Matthias Andree <matthias.andree@gmx.de>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.13-rc2
In-Reply-To: <20050707183928.GA14726@kroah.com>
References: <Pine.LNX.4.58.0507052126190.3570@g5.osdl.org>
	<42CBA650.8080004@eyal.emu.id.au>
	<Pine.LNX.4.58.0507060837510.3570@g5.osdl.org>
	<20050706155103.GA13115@kroah.com>
	<s5hy88j9cel.wl%tiwai@suse.de>
	<20050707183928.GA14726@kroah.com>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta18)
 (chestnut) (+CVS-20041021) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Thu, 7 Jul 2005 11:39:29 -0700,
Greg KH wrote:
> 
> On Thu, Jul 07, 2005 at 11:46:26AM +0200, Takashi Iwai wrote:
> > At Wed, 6 Jul 2005 08:51:03 -0700,
> > Greg KH wrote:
> > > 
> > > On Wed, Jul 06, 2005 at 08:42:16AM -0700, Linus Torvalds wrote:
> > > > 
> > > > 
> > > > On Wed, 6 Jul 2005, Eyal Lebedinsky wrote:
> > > > >
> > > > >   CC [M]  sound/pci/bt87x.o
> > > > > sound/pci/bt87x.c: In function `snd_bt87x_detect_card':
> > > > > sound/pci/bt87x.c:807: error: `driver' undeclared (first use in this function)
> > > > > sound/pci/bt87x.c:807: error: (Each undeclared identifier is reported only once
> > > > > sound/pci/bt87x.c:807: error: for each function it appears in.)
> > > > > sound/pci/bt87x.c: At top level:
> > > > > sound/pci/bt87x.c:910: error: `driver' used prior to declaration
> > > > 
> > > > This seems to be a thinko by Greg. That line got changed from
> > > > 
> > > > 	supported = pci_match_device(snd_bt87x_ids, pci);
> > > > 
> > > > to
> > > > 
> > > > 	supported = pci_match_device(driver, pci);
> > > > 
> > > > but as far as I can tell it _should_ be
> > > > 
> > > > 	supported = pci_match_id(snd_bt87x_ids, pci);
> > > 
> > > No, I wanted it to be "driver", but forgot to build the code, sorry.
> > > Try the following patch instead:
> > 
> > Well, I don't think pci_match_device() makes sense here.
> > snd_bt87x_detect_card() checks the sample rate of a known device
> > (listed in the static pci id table), and doesn't need to check the
> > dynamic devices.
> > Calling pci_match_id() would be more feasible.
> 
> Ok, that's fine with me if you want to do that instead.

Since Linus already applied the fix patches, I'll leave as it is ;)

pci_match_device() should work identically like pci_match_id() in the
above case since driver_data is 0.


thanks,

Takashi