From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E1D5C3527B for ; Mon, 9 May 2022 08:57:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237361AbiEII60 (ORCPT ); Mon, 9 May 2022 04:58:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237683AbiEIIrD (ORCPT ); Mon, 9 May 2022 04:47:03 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 247081C196C; Mon, 9 May 2022 01:43:08 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id A957A21BA8; Mon, 9 May 2022 08:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652085787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4fP40eSvF34iHipeWPs64su+UfsOQc7xa/5u//Nm++E=; b=ITLzDwznAxOYPqTy41JoGTKG+v0edPIP0By/fktrWFAshuA+WpFlpj3+R0WIPT81rTEHyL MMUDVuMYXOHKET57pu4W4RZjo1xwwlvSm0heY5ZIHeSuBiTHGk398aNQnDZqVEv/gg3hUs uTOomNZImpQR8nsTwDxCnXkbjWNBA1o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652085787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4fP40eSvF34iHipeWPs64su+UfsOQc7xa/5u//Nm++E=; b=buLvgq0UIGTEf49offxL6DOTTL+OwyuyXDtvho47b5RpYigc9W0x9/gOe5gG/MKc0Qm4mS cG4JvaBIOElIlWDg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 90DF82C141; Mon, 9 May 2022 08:43:07 +0000 (UTC) Date: Mon, 09 May 2022 10:43:07 +0200 Message-ID: From: Takashi Iwai To: Colin Ian King Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hdsp: remove redundant assignment to pointer kctl In-Reply-To: <20220508212819.59188-1-colin.i.king@gmail.com> References: <20220508212819.59188-1-colin.i.king@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 08 May 2022 23:28:19 +0200, Colin Ian King wrote: > > Pointer kctl is being assigned a value that is not being read, buf > is being re-assigned later. The assignment is redundant and can be > removed. > > Cleans up clang scan build warning: > sound/pci/rme9652/hdsp.c:3317:28: warning: Although the value stored > to 'kctl' is used in the enclosing expression, the value is never > actually read from 'kctl' [deadcode.DeadStores] > > Signed-off-by: Colin Ian King Thanks, applied. Takashi