From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89440C433E0 for ; Tue, 23 Feb 2021 06:39:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F10964E60 for ; Tue, 23 Feb 2021 06:39:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231527AbhBWGju (ORCPT ); Tue, 23 Feb 2021 01:39:50 -0500 Received: from mx2.suse.de ([195.135.220.15]:55600 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230105AbhBWGjr (ORCPT ); Tue, 23 Feb 2021 01:39:47 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BD137ACBF; Tue, 23 Feb 2021 06:39:05 +0000 (UTC) Date: Tue, 23 Feb 2021 07:39:05 +0100 Message-ID: From: Takashi Iwai To: Rajesh Kumbhakar Cc: perex@perex.cz, tiwai@suse.com, sfr@canb.auug.org.au, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: core: fixed coding style errors In-Reply-To: <20210222194156.26758-1-sssraj.sssraj@gmail.com> References: <20210222194156.26758-1-sssraj.sssraj@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Feb 2021 20:41:56 +0100, Rajesh Kumbhakar wrote: > > fixing ERROR: "foo * bar" should be "foo *bar" > fixing WARNING: Missing a blank line after declarations > > Signed-off-by: Rajesh Kumbhakar > --- > sound/core/hwdep_compat.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/core/hwdep_compat.c b/sound/core/hwdep_compat.c > index a0b76706c..d8624a14a 100644 > --- a/sound/core/hwdep_compat.c > +++ b/sound/core/hwdep_compat.c > @@ -36,11 +36,13 @@ enum { > SNDRV_HWDEP_IOCTL_DSP_LOAD32 = _IOW('H', 0x03, struct snd_hwdep_dsp_image32) > }; > > -static long snd_hwdep_ioctl_compat(struct file * file, unsigned int cmd, > +static long snd_hwdep_ioctl_compat(struct file *file, unsigned int cmd, > unsigned long arg) > { > struct snd_hwdep *hw = file->private_data; > + > void __user *argp = compat_ptr(arg); You shouldn't put a blank line here. thanks, Takashi