From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F32EC33CB1 for ; Tue, 14 Jan 2020 13:27:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF71A24679 for ; Tue, 14 Jan 2020 13:27:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728813AbgANN1V (ORCPT ); Tue, 14 Jan 2020 08:27:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:43666 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728767AbgANN1U (ORCPT ); Tue, 14 Jan 2020 08:27:20 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 006AFAC9A; Tue, 14 Jan 2020 13:27:18 +0000 (UTC) Date: Tue, 14 Jan 2020 14:27:18 +0100 Message-ID: From: Takashi Iwai To: Mark Brown Cc: Jeff Chang , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jeff_chang@richtek.com Subject: Re: [PATCH v6] ASoC: Add MediaTek MT6660 Speaker Amp Driver In-Reply-To: <20200114124744.GT3897@sirena.org.uk> References: <1578968526-13191-1-git-send-email-richtek.jeff.chang@gmail.com> <20200114124744.GT3897@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Jan 2020 13:47:44 +0100, Mark Brown wrote: > > On Tue, Jan 14, 2020 at 08:44:22AM +0100, Takashi Iwai wrote: > > Jeff Chang wrote: > > > > + if (ret < 0) > > > + return ret; > > > + reg_data = (u8)ret; > > > + if (on_off) > > > + reg_data &= (~0x01); > > > + else > > > + reg_data |= 0x01; > > > + return regmap_write(chip->regmap, MT6660_REG_SYSTEM_CTRL, reg_data); > > > Hm, this looks like an open-code of forced update bits via regmap. > > But interestingly there is no corresponding standard helper for that. > > Essentially it should be regmap_update_bits_base() with force=1. > > > Mark? > > regmap_write_bits(). Oh that obvious one, thanks :) Takashi