From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 198E2C4321D for ; Wed, 15 Aug 2018 16:01:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C48321486 for ; Wed, 15 Aug 2018 16:01:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C48321486 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729820AbeHOSyN (ORCPT ); Wed, 15 Aug 2018 14:54:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:42974 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729249AbeHOSyN (ORCPT ); Wed, 15 Aug 2018 14:54:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C01AEAD76; Wed, 15 Aug 2018 16:01:28 +0000 (UTC) Date: Wed, 15 Aug 2018 18:01:27 +0200 Message-ID: From: Takashi Iwai To: Borislav Petkov Cc: Tim Small , Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] EDAC: i82443bxgx: Fix invalid memory type assignment In-Reply-To: <20180815155752.GC28669@nazgul.tnic> References: <20180810141520.8993-1-tiwai@suse.de> <20180815155752.GC28669@nazgul.tnic> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Aug 2018 17:57:52 +0200, Borislav Petkov wrote: > > On Fri, Aug 10, 2018 at 04:15:20PM +0200, Takashi Iwai wrote: > > The i82443bxgx_edac driver assigns an invalid negative value when an > > unknown DRAM type is detected. Drop the unnecessary '-' that brings > > misbehavior. > > > > Fixes: 5a2c675c8919 ("drivers/edac: new i82443bxgz MC driver") > > Cc: > > Signed-off-by: Takashi Iwai > > --- > > drivers/edac/i82443bxgx_edac.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/edac/i82443bxgx_edac.c b/drivers/edac/i82443bxgx_edac.c > > index a2ca929e2168..1638f288fa47 100644 > > --- a/drivers/edac/i82443bxgx_edac.c > > +++ b/drivers/edac/i82443bxgx_edac.c > > @@ -273,7 +273,7 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx) > > break; > > default: > > edac_dbg(0, "Unknown/reserved DRAM type value in DRAMC register!\n"); > > - mtype = -MEM_UNKNOWN; > > + mtype = MEM_UNKNOWN; > > } > > > > if ((mtype == MEM_SDR) || (mtype == MEM_RDR)) > > -- > > Is this something you caught by inspection or you really have hw that > loads that driver... I just followed the old percept: read the source, Luke. > Wikipedia says 440BX chipset is pentium II and III which, if so, would > drop its priority considerably. CC:stable would be not needed either, TBH. OK, feel free to drop that. thanks, Takashi