mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Julia Lawall" <Julia.Lawall@lip6.fr>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
	<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: constify ct_timer_ops structures
Date: Sat, 09 Apr 2016 11:01:00 +0200	[thread overview]
Message-ID: <s5hh9fbcg1f.wl-tiwai@suse.de> (raw)
In-Reply-To: <1460190975-16270-1-git-send-email-Julia.Lawall@lip6.fr>

On Sat, 09 Apr 2016 10:36:15 +0200,
Julia Lawall wrote:
> 
> The ct_timer_ops structures are never modified, so declare them as const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Applied, thanks.


Takashi

> 
> ---
>  sound/pci/ctxfi/cttimer.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/pci/ctxfi/cttimer.c b/sound/pci/ctxfi/cttimer.c
> index a5d4604..8f94534 100644
> --- a/sound/pci/ctxfi/cttimer.c
> +++ b/sound/pci/ctxfi/cttimer.c
> @@ -49,7 +49,7 @@ struct ct_timer {
>  	spinlock_t lock;		/* global timer lock (for xfitimer) */
>  	spinlock_t list_lock;		/* lock for instance list */
>  	struct ct_atc *atc;
> -	struct ct_timer_ops *ops;
> +	const struct ct_timer_ops *ops;
>  	struct list_head instance_head;
>  	struct list_head running_head;
>  	unsigned int wc;		/* current wallclock */
> @@ -128,7 +128,7 @@ static void ct_systimer_prepare(struct ct_timer_instance *ti)
>  
>  #define ct_systimer_free	ct_systimer_prepare
>  
> -static struct ct_timer_ops ct_systimer_ops = {
> +static const struct ct_timer_ops ct_systimer_ops = {
>  	.init = ct_systimer_init,
>  	.free_instance = ct_systimer_free,
>  	.prepare = ct_systimer_prepare,
> @@ -322,7 +322,7 @@ static void ct_xfitimer_free_global(struct ct_timer *atimer)
>  	ct_xfitimer_irq_stop(atimer);
>  }
>  
> -static struct ct_timer_ops ct_xfitimer_ops = {
> +static const struct ct_timer_ops ct_xfitimer_ops = {
>  	.prepare = ct_xfitimer_prepare,
>  	.start = ct_xfitimer_start,
>  	.stop = ct_xfitimer_stop,
> 
> 

      reply	other threads:[~2016-04-09  9:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-09  8:36 Julia Lawall
2016-04-09  9:01 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hh9fbcg1f.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Julia.Lawall@lip6.fr \
    --cc=alsa-devel@alsa-project.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®