From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753291AbbAMQWR (ORCPT ); Tue, 13 Jan 2015 11:22:17 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41179 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751052AbbAMQWQ (ORCPT ); Tue, 13 Jan 2015 11:22:16 -0500 Date: Tue, 13 Jan 2015 17:22:13 +0100 Message-ID: From: Takashi Iwai To: Vinod Koul Cc: Qais Yousef , alsa-devel@alsa-project.org, Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly In-Reply-To: <20150113144549.GC3085@intel.com> References: <1418989110-10011-1-git-send-email-qais.yousef@imgtec.com> <54B5048F.2070709@imgtec.com> <20150113144549.GC3085@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 13 Jan 2015 20:15:49 +0530, Vinod Koul wrote: > > On Tue, Jan 13, 2015 at 11:42:07AM +0000, Qais Yousef wrote: > > Ping > > > > On 12/19/2014 11:38 AM, Qais Yousef wrote: > > >Fixes the following compilation error: > > > > > > include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’: > > > include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration] > > > if (snd_BUG_ON(!stream)) > > > > > >snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly, > > >so include it. > > > > > >Signed-off-by: Qais Yousef > > >Cc: Vinod Koul > > >Cc: Jaroslav Kysela > > >Cc: Takashi Iwai > > >Cc: linux-kernel@vger.kernel.org > > > > Looks okay to me > > Acked-by: Vinod Koul Applied now. Thanks. Takashi