From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751878AbaHSKfa (ORCPT ); Tue, 19 Aug 2014 06:35:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47388 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721AbaHSKf2 (ORCPT ); Tue, 19 Aug 2014 06:35:28 -0400 Date: Tue, 19 Aug 2014 12:35:21 +0200 Message-ID: From: Takashi Iwai To: "Li.Xiubo@freescale.com" Cc: "shengjiu.wang@freescale.com" , Lars-Peter Clausen , "lgirdwood@gmail.com" , "broonie@kernel.org" , "perex@perex.cz" , "nicoleotsuka@gmail.com" , "shc_work@mail.ru" , "Fabio.Estevam@freescale.com" , "xobs@kosagi.com" , "arnd@arndb.de" , "sfr@canb.auug.org.au" , "timur@tabi.org" , "alsa-devel@alsa-project.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA In-Reply-To: <3a0c98ca698e4d38b3e92f339049b883@BN1PR0301MB0609.namprd03.prod.outlook.com> References: <53F22F5E.2090601@metafoo.de> <20140819074103.GA5806@audiosh1> <20140819082108.GB5806@audiosh1> <3a0c98ca698e4d38b3e92f339049b883@BN1PR0301MB0609.namprd03.prod.outlook.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 19 Aug 2014 09:00:06 +0000, Li.Xiubo@freescale.com wrote: > > How about the following : > > > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig > index 5ae777a..d42f18c 100644 > --- a/sound/soc/fsl/Kconfig > +++ b/sound/soc/fsl/Kconfig > @@ -15,7 +15,7 @@ config SND_SOC_FSL_ASRC > config SND_SOC_FSL_SAI > tristate "Synchronous Audio Interface (SAI) module support" > select REGMAP_MMIO > - select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n > + select SND_SOC_IMX_PCM_DMA > select SND_SOC_GENERIC_DMAENGINE_PCM > help > Say Y if you want to add Synchronous Audio Interface (SAI) > @@ -25,7 +25,7 @@ config SND_SOC_FSL_SAI > > config SND_SOC_FSL_SSI > tristate "Synchronous Serial Interface module support" > - select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n > + select SND_SOC_IMX_PCM_DMA > select SND_SOC_IMX_PCM_FIQ if SND_IMX_SOC != n && (MXC_TZIC || MXC_AVIC) > select REGMAP_MMIO > help > @@ -37,7 +37,7 @@ config SND_SOC_FSL_SSI > config SND_SOC_FSL_SPDIF > tristate "Sony/Philips Digital Interface module support" > select REGMAP_MMIO > - select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n > + select SND_SOC_IMX_PCM_DMA > select SND_SOC_IMX_PCM_FIQ if SND_IMX_SOC != n && (MXC_TZIC || MXC_AVIC) > help > Say Y if you want to add Sony/Philips Digital Interface (SPDIF) > @@ -48,7 +48,7 @@ config SND_SOC_FSL_SPDIF > config SND_SOC_FSL_ESAI > tristate "Enhanced Serial Audio Interface (ESAI) module support" > select REGMAP_MMIO > - select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n > + select SND_SOC_IMX_PCM_DMA > help > Say Y if you want to add Enhanced Synchronous Audio Interface > (ESAI) support for the Freescale CPUs. > @@ -76,6 +76,7 @@ config SND_SOC_FSL_ASOC_CARD > > config SND_SOC_IMX_PCM_DMA > tristate > + depends on SND_IMX_SOC > select SND_SOC_GENERIC_DMAENGINE_PCM > > config SND_SOC_IMX_AUDMUX I see the problem has been addressed, so JFYI: a reverse selection doesn't resolve "depends on". It's a known shortcoming. That is, a selected item can select further others, but cannot depend on others. Takashi