mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Jaroslav Kysela <perex@perex.cz>,
	Jiri Kosina <trivial@kernel.org>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] trivial: sound/core/seq/seq_memory.c: Fix	closing brace followed by if
Date: Mon, 23 Jun 2014 17:44:43 +0200	[thread overview]
Message-ID: <s5hha3b1vh0.wl%tiwai@suse.de> (raw)
In-Reply-To: <1403293803-17650-1-git-send-email-linux@rasmusvillemoes.dk>

At Fri, 20 Jun 2014 21:50:03 +0200,
Rasmus Villemoes wrote:
> 
> Add a newline, and remove a space while at it.

This would give still a checkpatch warning.
Could you fix and resubmit?


thanks,

Takashi

> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
>  sound/core/seq/seq_memory.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/core/seq/seq_memory.c b/sound/core/seq/seq_memory.c
> index 1e206de..4854c21 100644
> --- a/sound/core/seq/seq_memory.c
> +++ b/sound/core/seq/seq_memory.c
> @@ -101,7 +101,8 @@ int snd_seq_dump_var_event(const struct snd_seq_event *event,
>  			len -= size;
>  		}
>  		return 0;
> -	} if (! (event->data.ext.len & SNDRV_SEQ_EXT_CHAINED)) {
> +	}
> +	if (!(event->data.ext.len & SNDRV_SEQ_EXT_CHAINED)) {
>  		return func(private_data, event->data.ext.ptr, len);
>  	}
>  
> -- 
> 1.9.2
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

  reply	other threads:[~2014-06-23 15:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20 19:50 Rasmus Villemoes
2014-06-23 15:44 ` Takashi Iwai [this message]
2014-06-23 15:56 ` [PATCH v2] " Rasmus Villemoes
2014-06-23 16:00   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hha3b1vh0.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=perex@perex.cz \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®