From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758168Ab3BGLEP (ORCPT ); Thu, 7 Feb 2013 06:04:15 -0500 Received: from cantor2.suse.de ([195.135.220.15]:53048 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755815Ab3BGLEN (ORCPT ); Thu, 7 Feb 2013 06:04:13 -0500 Date: Thu, 07 Feb 2013 12:04:11 +0100 Message-ID: From: Takashi Iwai To: H Hartley Sweeten Cc: Subject: Re: [PATCH 11/11] sound/pcmcia: use module_pcmcia_driver() in pcmcia drivers In-Reply-To: <201302061532.50523.hsweeten@visionengravers.com> References: <201302061532.50523.hsweeten@visionengravers.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 6 Feb 2013 15:32:50 -0700, H Hartley Sweeten wrote: > > Use the new module_pcmcia_driver() macro to remove the boilerplate > module init/exit code in the pcmcia drivers. > > Signed-off-by: H Hartley Sweeten Acked-by: Takashi Iwai (But please add subsystem maintainers to Cc at the next time...) Takashi > --- > sound/pcmcia/pdaudiocf/pdaudiocf.c | 15 +-------------- > sound/pcmcia/vx/vxpocket.c | 14 +------------- > 2 files changed, 2 insertions(+), 27 deletions(-) > > diff --git a/sound/pcmcia/pdaudiocf/pdaudiocf.c b/sound/pcmcia/pdaudiocf/pdaudiocf.c > index f9b5229..8f489de 100644 > --- a/sound/pcmcia/pdaudiocf/pdaudiocf.c > +++ b/sound/pcmcia/pdaudiocf/pdaudiocf.c > @@ -295,18 +295,5 @@ static struct pcmcia_driver pdacf_cs_driver = { > .suspend = pdacf_suspend, > .resume = pdacf_resume, > #endif > - > }; > - > -static int __init init_pdacf(void) > -{ > - return pcmcia_register_driver(&pdacf_cs_driver); > -} > - > -static void __exit exit_pdacf(void) > -{ > - pcmcia_unregister_driver(&pdacf_cs_driver); > -} > - > -module_init(init_pdacf); > -module_exit(exit_pdacf); > +module_pcmcia_driver(pdacf_cs_driver); > diff --git a/sound/pcmcia/vx/vxpocket.c b/sound/pcmcia/vx/vxpocket.c > index 8f93504..d4db7ec 100644 > --- a/sound/pcmcia/vx/vxpocket.c > +++ b/sound/pcmcia/vx/vxpocket.c > @@ -367,16 +367,4 @@ static struct pcmcia_driver vxp_cs_driver = { > .resume = vxp_resume, > #endif > }; > - > -static int __init init_vxpocket(void) > -{ > - return pcmcia_register_driver(&vxp_cs_driver); > -} > - > -static void __exit exit_vxpocket(void) > -{ > - pcmcia_unregister_driver(&vxp_cs_driver); > -} > - > -module_init(init_vxpocket); > -module_exit(exit_vxpocket); > +module_pcmcia_driver(vxp_cs_driver); > -- > 1.8.1.1.293.gfe73786 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >